Fix issue with DateInput #6693
Merged
Fix issue with DateInput #6693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfilben
approved these changes
Mar 27, 2023
ericsoderberghp
approved these changes
Mar 27, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There is an issue in an inline ranged DateInput where if you type a date and then click that date in the calendar to deselect it, the component simply breaks. It will return nonsensical values to its onChange handler and will display NaN in the date text input. It is not recoverable from this state.
This PR fixes that issue.
Where should the reviewer start?
Testing in storybook I suppose.
What testing has been done on this PR?
It has been tested using a jest test and manually tested in storybook.
How should this be manually tested?
You can repro by going to this story: https://storybook.grommet.io/?path=/story/input-dateinput-format-inline--format-inline and then type a date and then click that date in the calendar to deselect it.
Do Jest tests follow these best practices?
screenis used for querying.userEventis used in place offireEvent.asFragment()is used for snapshot testing.Screenshots (if appropriate)
Do the grommet docs need to be updated?
No
Should this PR be mentioned in the release notes?
Maybe?
Is this change backwards compatible or is it a breaking change?
Backwards compatible.