Update status-error color to fix Form/AggregateValidation a11y violation #6690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Júlia Albuquerque <julia.albq@gmail.com>
|
@ericsoderberghp This change resolves the accessibility issue. Are there any concerns with this change? I'm not sure if there are any specific considerations for the grommet color palette that we need to keep in mind or if we should have a designer review this change? |
ericsoderberghp
approved these changes
Mar 28, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix status-error contrast violation in Form/AggregateValidation.
fixes #6470
Where should the reviewer start?
src/js/themes/base.js.
What testing has been done on this PR?
yarn testwas run before committing.How should this be manually tested?
Check the accessibility tab in the Form/AggregateValidation storybook.
Do Jest tests follow these best practices?
screenis used for querying.userEventis used in place offireEvent.asFragment()is used for snapshot testing.Any background context you want to provide?
What are the relevant issues?
#6470
Screenshots (if appropriate)
Do the grommet docs need to be updated?
No.
Should this PR be mentioned in the release notes?
No.
Is this change backwards compatible or is it a breaking change?
Is backwards compatible.