Skip to content

Changed SelectMultiple to improve help styling #6685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 16, 2023

Conversation

ericsoderberghp
Copy link
Contributor

What does this PR do?

Changed SelectMultiple to improve help styling

Where should the reviewer start?

SelectMultipleContainer.js

What testing has been done on this PR?

Added a story

How should this be manually tested?

Storybook "Help"

Do Jest tests follow these best practices?

no changes to unit tests

Any background context you want to provide?

uncovered via use with grommet-designer

What are the relevant issues?

Screenshots (if appropriate)

Do the grommet docs need to be updated?

no

Should this PR be mentioned in the release notes?

yes

Is this change backwards compatible or is it a breaking change?

backwards compatible

Copy link
Collaborator

@taysea taysea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ericsoderberghp ericsoderberghp merged commit a66456e into master Mar 16, 2023
@ericsoderberghp ericsoderberghp deleted the fix/selectmultiple-help branch March 16, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants