Fix issue with tips for truncated text when switching pages in a table #6682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taysea
reviewed
Mar 30, 2023
taysea
reviewed
Mar 30, 2023
taysea
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Resolve issue described here with truncated text: #6659. The issue occurs because tips for truncated text are not being updated when switching pages in a table. Resolved by dispatching an event "paginationupdate" in pagination.js when page is changed and adding an event listener in Text.js to call updateTip.
Where should the reviewer start?
Start with file pagination.js
What testing has been done on this PR?
Tested manually and ran test suite.
How should this be manually tested?
We can use the storybook component Visualization -> DataTable -> Pagination for testing. The data in pagination.tsx can be updated with truncated text. The pagination.tsx file with local changes I made for testing can be found here: https://gist.github.com/vbanda28/84db2a7872a4183a0ee9dce031c96164
Do Jest tests follow these best practices?
screenis used for querying.userEventis used in place offireEvent.asFragment()is used for snapshot testing.Any background context you want to provide?
What are the relevant issues?
#6659
Screenshots (if appropriate)
Do the grommet docs need to be updated?
No
Should this PR be mentioned in the release notes?
Yes
Is this change backwards compatible or is it a breaking change?
Backwards compatible