Apply line-height 0 for iconOnly buttons #6666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
halocline
approved these changes
Mar 6, 2023
ericsoderberghp
approved these changes
Mar 6, 2023
This was referenced Mar 9, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Applies
line-height: 0for icon-only buttons. This is a required fix for Safari and does not have any visual effects on other browsers. Safari improperly determined a button's dimensions in cases where only icon property was applied, no label.Where should the reviewer start?
src/js/components/Button/StyledButtonKind.js
What testing has been done on this PR?
See screenshots below. Tested locally in storybook using NEXT branch of grommet-theme-hpe. This can also be tested directly in a browser (current HPE Design System site exhibits this bug. For example, the "Search" button in main header has 39px height as opposed to 36px). Applying line-height 0 to the button fixes it.
How should this be manually tested?
See above notes.
Do Jest tests follow these best practices?
screenis used for querying.userEventis used in place offireEvent.asFragment()is used for snapshot testing.Any background context you want to provide?
What are the relevant issues?
Closes #6667
Screenshots (if appropriate)
BEFORE
AFTER
BEFORE (grommet-theme-hpe NEXT)
AFTER
Do the grommet docs need to be updated?
No.
Should this PR be mentioned in the release notes?
Yes.
Is this change backwards compatible or is it a breaking change?
Backwards compatible.