Changed Data to handle property paths #6645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfilben
reviewed
Feb 22, 2023
taysea
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes Data to handle nested objects in the data as properties.
Now, you can use
properties={ 'location.city': { ...} }and it will do what you might suspect.Also, I combined
optionsandrangeinto a singleuseMemo()in DataFilter to be more efficient.Where should the reviewer start?
Take a look at the new Complex story under Data.
What testing has been done on this PR?
Added the Complex story to test interaction with both range and options versions.
How should this be manually tested?
Complex story
Do Jest tests follow these best practices?
no jest changes
Any background context you want to provide?
What are the relevant issues?
#6638
Screenshots (if appropriate)
Do the grommet docs need to be updated?
yes
Should this PR be mentioned in the release notes?
yes
Is this change backwards compatible or is it a breaking change?
backwards compatible