-
Notifications
You must be signed in to change notification settings - Fork 1k
Allow size specific Anchor theme #6643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ericsoderberghp
merged 6 commits into
grommet:master
from
taysea:6636-anchor-size-theme
Feb 21, 2023
Merged
Allow size specific Anchor theme #6643
ericsoderberghp
merged 6 commits into
grommet:master
from
taysea:6636-anchor-size-theme
Feb 21, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halocline
reviewed
Feb 21, 2023
halocline
approved these changes
Feb 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we will want to use TextContext within Paragraph as well, in case an Anchor is used there.
ericsoderberghp
approved these changes
Feb 21, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR enhances
theme.anchor
to allowtheme.anchor.size[size].color
,theme.anchor.size[size].fontWeight
,theme.anchor.size[size].textDecoration
.TextContext is necessary because an anchor embedded in text may not receive an explicit size prop but needs to be "size-aware" of the text it is embedded within.
Where should the reviewer start?
src/js/components/Anchor/Anchor.js
What testing has been done on this PR?
Tested local in storybook and added jest tests
How should this be manually tested?
Local in Size story:
Do Jest tests follow these best practices?
screen
is used for querying.userEvent
is used in place offireEvent
.asFragment()
is used for snapshot testing.Any background context you want to provide?
What are the relevant issues?
Closes #6636
Screenshots (if appropriate)
Do the grommet docs need to be updated?
Should this PR be mentioned in the release notes?
Yes. Enhanced Anchor to support size-specific theming.
Is this change backwards compatible or is it a breaking change?
Backwards compatible.