add support for border between in border array #6642
Conversation
There was a problem hiding this comment.
Nice work so far! It looks like there may be a few other places in Box.js where we may want to check if border is an array and it container side='between'. See line 103 of Box.js where it has if ( (border === 'between' || (border && border.side === 'between')) && !gap ). Also see line 221 where we have gap={ (boxOptions?.cssGap || cssGap) && gap && gap !== 'none' && border !== 'between' && border?.side !== 'between' && gap }
@jcfilben Do you think that the refinement requests you listed should block this current PR? or can we file a separate issue to track it? |
It looks like the changes requested already made their way into the PR. So no need to file a separate issue for this. |
What does this PR do?
Add support for using between border in border array props
Where should the reviewer start?
Box.jsWhat testing has been done on this PR?
yarn testpassedHow should this be manually tested?
A storybook example added
Do Jest tests follow these best practices?
screenis used for querying.userEventis used in place offireEvent.asFragment()is used for snapshot testing.Any background context you want to provide?
What are the relevant issues?
#6640
Screenshots (if appropriate)
Do the grommet docs need to be updated?
No
Should this PR be mentioned in the release notes?
Is this change backwards compatible or is it a breaking change?
Compatible