Make rowProps work on group header rows #6627
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes it possible in
DataTable
to userowProps
to target group header rows. The 'key' for a group header is the value of the data member property specified bygroupBy
.For example, in the code below the data is grouped by the data property
location
. One of the values oflocation
is "Fort Collins". By including an member in therowProps
object with the keyFort Collins
we specify row properties for the group header for the "Fort Collins" group.Where should the reviewer start?
GroupedBody.js
What testing has been done on this PR?
Manual and Storybook
How should this be manually tested?
I tested this by adding
rowProps
to the DataTable/Grouped storybook example:Do Jest tests follow these best practices?
screen
is used for querying.userEvent
is used in place offireEvent
.asFragment()
is used for snapshot testing.Any background context you want to provide?
What are the relevant issues?
Fixes #6625
Screenshots (if appropriate)
Do the grommet docs need to be updated?
No
Should this PR be mentioned in the release notes?
Yes
Is this change backwards compatible or is it a breaking change?
backwards compatible