Changed DataTable to not default to height: 100% #6590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm having a hard time seeing the difference between the two screenshots in the PR description |
The rows are different heights. In the prior version, the table would stretch to 100% height, causing the rows to stretch out taller. In the newer version, the rows control their own height and they remain so. |
Ah okay I see it now, thanks |
jcfilben
approved these changes
Jan 19, 2023
3 tasks
taysea
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changed DataTable to not default to
height: 100%;I was noticing odd layout behavior across a variety of screen resolutions with DataTable and traced it down to all DataTables having
height: 100%;causing them not to get laid out correctly. In many circumstances this wouldn't be noticed. It also explain the need at times to wrap DataTable in a Box to get it to behave better.Where should the reviewer start?
one line change
What testing has been done on this PR?
<Data />componentHow should this be manually tested?
evaluate storybook stories at various screen resolutions
Do Jest tests follow these best practices?
no test changes
Screenshots (if appropriate)
prior Data -> DataTable story:
new Data -> DataTable story:
Do the grommet docs need to be updated?
no
Should this PR be mentioned in the release notes?
yes
Is this change backwards compatible or is it a breaking change?
If
fillis set then there is no change. Iffillis not set, then some of the workarounds to get the table to layout correctly will not be needed anymore. There could be visual changes at certain resolutions but I would argue those are defects.