Remove unnecessary focus() on List click #6579
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a List allows clicking on items via the
onClickItem
, it sets focus on the List container for various reasons including accessibility and WCAG compliance. However that .focus() causes the the browser to automatically scroll the container in some cases even though it's not necessary in this situation.What does this PR do?
This removes the call to set focus() on the List container on item click. It turns out this really doesn't seem to be needed anymore. Without this extra focus() call, clicking on an item does cause the container to get focus, and it does it without causing an extra scroll attempt to make sure it's visible (which isn't needed in this situation.)
Where should the reviewer start?
List.js
What testing has been done on this PR?
Manual, jest, existing storybook.
How should this be manually tested?
Before the change the List will scroll so it's at the very top of the viewport. After the change the List will not scroll (arrowing around or using the Tab key to navigate can still cause the viewport to scroll as needed.)
Do Jest tests follow these best practices?
screen
is used for querying.userEvent
is used in place offireEvent
.asFragment()
is used for snapshot testing.Any background context you want to provide?
What are the relevant issues?
Fixes #6574
Screenshots (if appropriate)
Do the grommet docs need to be updated?
No
Should this PR be mentioned in the release notes?
Not required but...yes
Is this change backwards compatible or is it a breaking change?
Backwards compatible