Fix Form onBlur validation with drop components #6566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taysea
reviewed
Jan 6, 2023
taysea
reviewed
Jan 6, 2023
taysea
reviewed
Jan 6, 2023
Co-authored-by: Taylor Seamans <taylor.seamans@yahoo.com>
|
Converting this PR to a draft, I realized this solution isn't working well when a Form is contained within a Layer due to the |
taysea
reviewed
Jan 10, 2023
| const dropPortalId = withinDropPortal(event.relatedTarget); | ||
| if ( | ||
| (dropPortalId === undefined || | ||
| portalContext.indexOf(parseInt(dropPortalId, 10)) !== -1) && |
There was a problem hiding this comment.
Can we add a small comment speaking to what portalContext is doing here?
There was a problem hiding this comment.
Yes, some code moved around after I incorporated Eric's feedback so I ended up adding a comment in the utils/dom.js file to explain this
ericsoderberghp
approved these changes
Jan 13, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an issue where onBlur validation was running prematurely on components with drops (Select, SelectMultiple, DateInput) when the drop is opened.
Where should the reviewer start?
What testing has been done on this PR?
Tested with storybook story and added a jest test
How should this be manually tested?
Do Jest tests follow these best practices?
screenis used for querying.userEventis used in place offireEvent.asFragment()is used for snapshot testing.Any background context you want to provide?
What are the relevant issues?
Closes #5538
Screenshots (if appropriate)
Do the grommet docs need to be updated?
No
Should this PR be mentioned in the release notes?
Yes
Is this change backwards compatible or is it a breaking change?
Backwards compatible