(Collapsible) fix: enable animation when initial open prop is true #6535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -77,7 +77,7 @@ const Collapsible = forwardRef( | |||
| collapsible: { minSpeed, baseline }, | |||
| } = theme; | |||
| const nextSpeed = Math.max( | |||
| (sizeRef.current / baseline) * minSpeed, | |||
| ((sizeRef.current || 0) / baseline) * minSpeed, | |||
There was a problem hiding this comment.
I think a cleaner way to do this would be to adjust the useRef to be useRef(0), that way it starts with an initial value.
a6c9da3 to
92ab28e
Compare
92ab28e to
205ff66
Compare
jcfilben
approved these changes
Dec 15, 2022
ericsoderberghp
approved these changes
Dec 16, 2022
This was referenced Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes animation speed value. When component is open on init
nextSpeedvalue isNaNbecause sizeRef returns undefined at this point and this value is used in nextSpeed computation.Where should the reviewer start?
Collapsible.js
What testing has been done on this PR?
manual
How should this be manually tested?
set initial open prop to true
Do Jest tests follow these best practices?
screenis used for querying.userEventis used in place offireEvent.asFragment()is used for snapshot testing.Any background context you want to provide?
What are the relevant issues?
Closes #6523
Screenshots (if appropriate)
Do the grommet docs need to be updated?
no
Should this PR be mentioned in the release notes?
yes
Is this change backwards compatible or is it a breaking change?
no