Refactored List key/value handling to reduce code duplication and fix issues with itemKey being a function when ordering #6478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… issues with itemKey being a function when ordering
MikeKingdom
reviewed
Nov 3, 2022
MikeKingdom
approved these changes
Nov 3, 2022
This was referenced Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactored List key/value handling to reduce code duplication and fix issues with itemKey being a function when ordering.
Without this change, if
itemKeywas a function then the list ordering wouldn't work because it was only treating it as a string:This issue was uncovered within grommet-designer.
Where should the reviewer start?
List.js
What testing has been done on this PR?
unit tests
various storybook stories
used with grommet-designer to re-order grouped Menu items
How should this be manually tested?
storybook
Do Jest tests follow these best practices?
no tests were canged
Any background context you want to provide?
See above
What are the relevant issues?
no issue
Do the grommet docs need to be updated?
no
Should this PR be mentioned in the release notes?
yes
Is this change backwards compatible or is it a breaking change?
backwards compatible