You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
Should we add number to the other places in base.d.ts that use zIndex. I think if we change it in one place it would make sense to change it in the other places as well. I think there are only three other places zIndex is defined in base.d.ts
Should we add number to the other places in base.d.ts that use zIndex. I think if we change it in one place it would make sense to change it in the other places as well. I think there are only three other places zIndex is defined in base.d.ts
I didn't check other places of this prop, their use cases, or how critical their change would be. I fixed this one because it was breaking locally and it is supported for no TS users.
Should we add number to the other places in base.d.ts that use zIndex. I think if we change it in one place it would make sense to change it in the other places as well. I think there are only three other places zIndex is defined in base.d.ts
I didn't check other places of this prop, their use cases, or how critical their change would be. I fixed this one because it was breaking locally and it is supported for no TS users.
That's fair we can go back and assess the other area but do not want to block you on this one.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the zIndex type for drop on the theme object
Where should the reviewer start?
base.d.ts
What testing has been done on this PR?
local
How should this be manually tested?
TS storybook
Do Jest tests follow these best practices?
N/A
Any background context you want to provide?
What are the relevant issues?
Not sure
Screenshots (if appropriate)
Do the grommet docs need to be updated?
No
Should this PR be mentioned in the release notes?
Yes, TS fix
Is this change backwards compatible or is it a breaking change?
backwards compatible