Form/AggregateValidation label violation fixed #6469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jashanshah33 <jashanshah33@gmail.com>
jcfilben
reviewed
Oct 31, 2022
There was a problem hiding this comment.
Same question as #6464 (comment). It seems like if we provide a label to FormField and don't have an aria-label or a11yTitle that should be used as the aria-label. This would take care of the accessibility issue and we wouldn't need to change anything about this story
|
Hi @jcfilben , |
If the form has a label and neither aria-label or a11yTitle are defined, the aria-label should be the form label |
Co-authored-by: Jessica Filben <54560994+jcfilben@users.noreply.github.com>
Co-authored-by: Jessica Filben <54560994+jcfilben@users.noreply.github.com>
ericsoderberghp
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixed label issues in storybook for AggregateValidation
Where should the reviewer start?
storybook
What testing has been done on this PR?
local
How should this be manually tested?
storybook
Do Jest tests follow these best practices?
none
Any background context you want to provide?
no
What are the relevant issues?
#6124
Screenshots (if appropriate)
Before:
After:
Do the grommet docs need to be updated?
no
Should this PR be mentioned in the release notes?
no
Is this change backwards compatible or is it a breaking change?
backwards compatible