Skip to content

Conversation

ShimiSun
Copy link
Collaborator

@ShimiSun ShimiSun commented Oct 28, 2022

What does this PR do?

Fix axe issues for Form DynamicFields

Where should the reviewer start?

storybook file

What testing has been done on this PR?

local

How should this be manually tested?

storybook

Do Jest tests follow these best practices?

N/A

Any background context you want to provide?

no

What are the relevant issues?

#6124

Screenshots (if appropriate)

image (3)

image (2)

#### Do the grommet docs need to be updated? no #### Should this PR be mentioned in the release notes? no #### Is this change backwards compatible or is it a breaking change? b-c

Copy link
Collaborator

@jcfilben jcfilben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ShimiSun
Copy link
Collaborator Author

ShimiSun commented Nov 7, 2022

Looks good!

Are pending action items needed for this one to get it merged?

@ericsoderberghp ericsoderberghp merged commit 895e8ef into master Nov 8, 2022
@ericsoderberghp ericsoderberghp deleted the fix/axe-form branch November 8, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants