Fix types of drop props in components #6463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsoderberghp
approved these changes
Oct 31, 2022
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It's a follow-up to #6431
The goal is for
dropPropsto acceptstyleas a property. This behavior already exists in DateInput, Tip, but also needs alignment for other components as this PR suggests.Where should the reviewer start?
Any ts file
What testing has been done on this PR?
local
How should this be manually tested?
Use
styleprop withdropPropsbefore/after the fix.Do Jest tests follow these best practices?
N/A
Any background context you want to provide?
It's a follow-up to #6431
What are the relevant issues?
Any bucket of TS bugs.
Screenshots (if appropriate)
Do the grommet docs need to be updated?
nope
Should this PR be mentioned in the release notes?
Yes, as a TS fix.
Is this change backwards compatible or is it a breaking change?
Yes. It extends the type of
dropProps