Skip to content

Conversation

pradokez
Copy link
Contributor

What does this PR do?

Fixes Storybook Accessibility issues in Markdown/stories/Override component

Where should the reviewer start?

Markdown/stories/Override.js

What testing has been done on this PR?

  • manual testing
  • none of the existing tests broke

How should this be manually tested?

Check the accessibility tab in Markdown/Override in storybook.

Do Jest tests follow these best practices?

changes don't affect tests

  • The correct query is used. (Refer to this list of queries)
  • userEvent is used in place of fireEvent.
  • asFragment() is used for snapshot testing.
  • Any background context you want to provide?

What are the relevant issues?

#6124

Screenshots (if appropriate)

image

Do the grommet docs need to be updated?

There's no need

Should this PR be mentioned in the release notes?

Is this change backwards compatible or is it a breaking change?

Copy link
Collaborator

@jcfilben jcfilben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ericsoderberghp ericsoderberghp merged commit 4d23fd5 into grommet:master Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants