Fix Storybook accessibility violations for the range input (#6124) #6423
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
This should fix up the accessibility violations reported across multiple
RangeInput
component stories.As an aside, I noticed
a11yTitle
feeds intoaria-label
of the underlying styled range input. Having looked atFileInput
just the other day, the latter doesn't appear to do the same, so this might be a potential inconsistency worth reviewing?In any case, there's no reason why we can't also fix the violations here by directly specifying
aria-label
instead ofa11yTitle
because theRangeInput
appears to feed everything through as spread props.What does this PR do?
Resolves an accessibility violations for the
RangeInput
component.Where should the reviewer start?
Across the various stories of the
RangeInput
component.What testing has been done on this PR?
Confirmed the violations no longer appear in Storybook.
How should this be manually tested?
As above.
Do Jest tests follow these best practices?
N/A.
screen
is used for querying.userEvent
is used in place offireEvent
.asFragment()
is used for snapshot testing.Any background context you want to provide?
None.
What are the relevant issues?
Refer to #6124.
Screenshots (if appropriate)
N/A.
Do the grommet docs need to be updated?
Don't think so.
Should this PR be mentioned in the release notes?
Up to maintainers to decide.
Is this change backwards compatible or is it a breaking change?
Should have no impact on consumers of the library.