Correct types for onChange() params of FileInput #6418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It corrects types definitions for additional params of
onChangeproperty ofFileInputcomponent.Where should the reviewer start?
FileInputcomponent.What testing has been done on this PR?
Manual testing with the app that's using TypeScript.
How should this be manually tested?
Add
FileInputwithonChangeproperty to the render of your component. Try to describe params ofonChangeprecisely.What are the relevant issues?
#6145 (the fix is incomplete).
Do the grommet docs need to be updated?
No.
Should this PR be mentioned in the release notes?
I think yes.
Is this change backwards compatible or is it a breaking change?
This change might break an app which has incorrect handling of second parameter of
onChange(e.g., referring to property offileswhich doesn't actually exist, but TS wouldn't warn about this with current type definition).