Fix Storybook accessibility violations for the carousel (#6124) #6414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsoderberghp
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
This should fix up the accessibility violations being reported for the "Multi" story of the
Carouselcomponent.Did my best with the captioning, but happy to change if necessary.
What does this PR do?
Resolves accessibility violations for
Carouselcomponent in Storybook.Where should the reviewer start?
All changes are within "Multi" story.
What testing has been done on this PR?
Manually confirmed that Storybook no longer reports the accessibility violations.
How should this be manually tested?
As above.
Do Jest tests follow these best practices?
N/A.
screenis used for querying.userEventis used in place offireEvent.asFragment()is used for snapshot testing.Any background context you want to provide?
None.
What are the relevant issues?
Refer to #6124.
Screenshots (if appropriate)
N/A.
Do the grommet docs need to be updated?
Don't think so.
Should this PR be mentioned in the release notes?
Up to maintainers to decide.
Is this change backwards compatible or is it a breaking change?
Should have no impact on consumers of the library.