Changed DataChart to better match legend style to chart style #6411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changed DataChart to better match legend style to chart style.
Previously, opacity wasn't preserved, as can be seen with the legend here:
Now, the legend more accurately aligns to the styling of each property.
This was done by refactoring how the
seriesStylesare built. That is the essence of these changes. Each chart can set styling, like color and opacity, but also each property can have its own styling for chart types like stacked "bars", "lines", and "areas". In the refactored code,setPropertyStyle()is now used across the various permutations and it is passed an object that spreads the chart styles first and then lets any per-property styles supersede them.Where should the reviewer start?
DataChart.js where
seriesStylesare built, about line 324.What testing has been done on this PR?
Enhanced the Legend and Stacked Bars stories.
How should this be manually tested?
DataChart stories
Do Jest tests follow these best practices?
no changes to tests, no unit tests were broken in the changing of this code ;)
Do the grommet docs need to be updated?
no
Should this PR be mentioned in the release notes?
yes
Is this change backwards compatible or is it a breaking change?
backwards compatible