Mouse Wheel to control RangeInput Value #5693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GurkiranSingh <gurkiransinghk@gmail.com>
Signed-off-by: GurkiranSingh <gurkiransinghk@gmail.com>
jcfilben
reviewed
Oct 18, 2021
Signed-off-by: GurkiranSingh <gurkiransinghk@gmail.com>
halocline
reviewed
Oct 20, 2021
Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com>
|
Looks like the snapshots just need to be updated. Run |
Signed-off-by: GurkiranSingh <gurkiransinghk@gmail.com>
jcfilben
approved these changes
Oct 21, 2021
| const handleMouseOver = () => { | ||
| const x = window.scrollX; | ||
| const y = window.scrollY; | ||
| window.onscroll = () => window.scrollTo(x, y); |
There was a problem hiding this comment.
This doesn't feel like the right React way to do things. If something else has already hooked into window.onscroll? Instead, I think we should save the window.scrollX and window.scrollY into a state variable and then use an effect hook to add and remove the event listener via addEventListener.
Signed-off-by: GurkiranSingh <gurkiransinghk@gmail.com>
ericsoderberghp
approved these changes
Oct 21, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: GurkiranSingh gurkiransinghk@gmail.com
What does this PR do?
Mouse wheel to control RangeInput value
Where should the reviewer start?
components => RangeInput
What testing has been done on this PR?
Pre-written tests are passing successfully.
How should this be manually tested?
Using storybook, hover over the RangeInput and using mouse wheel to control the value.
Any background context you want to provide?
What are the relevant issues?
Closes #5664
Screenshots (if appropriate)
Do the grommet docs need to be updated?
No
Should this PR be mentioned in the release notes?
Is this change backwards compatible or is it a breaking change?
Backwards Compatible