Truncate tip #5462
Merged
Truncate tip #5462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces PR #5453
What does this PR do?
When truncate="tip", if the text has been truncated, the entirety of the text will be placed in a Tip.
Where should the reviewer start?
src/js/components/Text/Text.js
What testing has been done on this PR?
Adjusted Tip.js story to demo truncate="tip".
How should this be manually tested?
Checkout deploy Tip.js under Text stories.
Any background context you want to provide?
Minimize implementation effort to be able to place truncated content into a tip.
What are the relevant issues?
Related to: grommet/hpe-design-system#1503
Related to: grommet/hpe-design-system#1734
Screenshots (if appropriate)
Do the grommet docs need to be updated?
Updated here.
Should this PR be mentioned in the release notes?
Yes. Added truncate="tip" to Text.
Is this change backwards compatible or is it a breaking change?
Backwards compatible.