added storybook example of themecontext.consumer #3612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShimiSun
reviewed
Dec 11, 2019
| <div style={{ backgroundColor: theme.global.colors['neutral-3'] }}> | ||
| <p style={{ color: theme.global.colors['light-1'] }}> | ||
| {' '} | ||
| This is not a grommet component |
There was a problem hiding this comment.
Suggested change
| This is not a grommet component | |
| This component is leveraging the grommet theme capabilities although it is not a grommet component |
what do you think?
| </Grommet> | ||
| ); | ||
|
|
||
| storiesOf('Theme', module).add('Theme Context', () => <CustomDefaultProps />); |
There was a problem hiding this comment.
Suggested change
| storiesOf('Theme', module).add('Theme Context', () => <CustomDefaultProps />); | |
| storiesOf('Theme', module).add('External components', () => <CustomDefaultProps />); |
what do you think?
ShimiSun
suggested changes
Jan 21, 2020
| import { grommet } from 'grommet/themes'; | ||
| import { Box, Text, ThemeContext, Grommet } from 'grommet'; | ||
|
|
||
| const CustomDefaultProps = () => ( |
There was a problem hiding this comment.
This component name doesn't make sense to me.
ExternalComponentWithTheme would make sense to me, feel free to make other suggestions.
changed name of component to ExternalComponentWithTheme
ShimiSun
approved these changes
Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds example for using themecontext.consumer to add theme properties to non grommet components
Where should the reviewer start?
src/js/contexts/ThemeContext/theme-context.stories.js