-
Notifications
You must be signed in to change notification settings - Fork 1k
Closed
Labels
Data and friendsFor data components in grommetFor data components in grommetbugissue that does not match design or documentation and requires code changes to addressissue that does not match design or documentation and requires code changes to address
Description
Having both DataSort
and DataFilters
results in some strange behavior. After selecting ‘sort by’ and ‘sort direction’ those fields show up in DataFilters. It feels like they should not show up in DataFilters.
This behavior is coming from https://github.com/grommet/grommet/blob/master/src/js/components/DataFilters/DataFilters.js#L110-L112
If DataFilters
doesn't have children and view.sort
is defined, DataFilters
will include DataSort
within.
What is the 80% case when using DataSort. Do we expect it should be within DataFilters or a separate control?
URL, screen shot, or Codepen exhibiting the issue
Dec-13-2023.10-21-02.mp4
Steps to Reproduce
- https://storybook.grommet.io/?path=/story/data-data-properties--properties
- Notice the DataFilters drop initially only shows a location filter
- Open the DataSort drop and select a property to sort by and a direction
- Open the DataFilters drop. Notice the drop content now includes DataSort.
Metadata
Metadata
Assignees
Labels
Data and friendsFor data components in grommetFor data components in grommetbugissue that does not match design or documentation and requires code changes to addressissue that does not match design or documentation and requires code changes to address