-
Notifications
You must be signed in to change notification settings - Fork 1k
Closed
Labels
bugissue that does not match design or documentation and requires code changes to addressissue that does not match design or documentation and requires code changes to address
Description
There is an error in select multiple when using object values in conjunction with showSelectedInline, when the inline item is clicked instead of de-selecting that item it ends up being the only item selected
Expected Behavior
Unselect an inline item when clicked
Actual Behavior
When clicking an inline item it ends up being the only item selected
URL, screen shot, or Codepen exhibiting the issue
The error happens all the time, it is easy to check it in the storybook
(https://storybook.grommet.io/?path=/story/input-selectmultiple-object-options--object-options)
the error is in the line (
grommet/src/js/components/SelectMultiple/SelectMultipleValue.js
Lines 94 to 96 in bcf727d
? applyKey(v, valueKey || labelKey) === | |
applyKey(optionValue, valueKey || labelKey) | |
: v !== optionValue, |
the object comparison should be !== like the string value comparison, but it is using ===
Metadata
Metadata
Assignees
Labels
bugissue that does not match design or documentation and requires code changes to addressissue that does not match design or documentation and requires code changes to address