Skip to content

Type for select value isn't right #6522

@mrmagcore

Description

@mrmagcore

This is the current type declaration for Select:

export interface SelectProps extends BasicSelectProps {
clear?: boolean | { position?: 'top' | 'bottom'; label?: string };
closeOnChange?: boolean;
defaultValue?: string | number | object | (string | number | object)[];
multiple?: boolean;
selected?: number | number[];
value?: string | JSX.Element | object | (string | number | object)[];
}

but the docs say that value can be a number too, so I would recommend updating components/Select/index.d.ts to say this.

export interface SelectProps extends BasicSelectProps {
clear?: boolean | { position?: 'top' | 'bottom'; label?: string };
closeOnChange?: boolean;
defaultValue?: string | number | object | (string | number | object)[];
multiple?: boolean;
selected?: number | number[];
value?: string | number | JSX.Element | object | (string | number | object)[];
}

I'd file a pull request, but I don't know how.

Metadata

Metadata

Assignees

Labels

good first issueA good one to work on if you are just getting started with grommettypescriptTypescript enhancements and bugs

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions