-
Notifications
You must be signed in to change notification settings - Fork 1k
Closed
Labels
bugissue that does not match design or documentation and requires code changes to addressissue that does not match design or documentation and requires code changes to addresshacktoberfestPRs submitted in October (open-source celebration month)PRs submitted in October (open-source celebration month)
Description
Expected Behavior
When clicking outside of Drop/Select Drop with a custom containerTarget
, the drop should close itself.
Actual Behavior
When clicking outside of Drop/Select Drop with a custom containerTarget
, the application crash on Firefox.
This issue seems to come from this fix : #6120
The code used the field path
which is non standard.
TypeError
event.path is undefined
onClickDocument
https://z9939s.csb.app/node_modules/grommet/es6/components/Drop/DropContainer.js:211:85
EventListener.handleEvent*$csb$eval/DropContainer</<
https://z9939s.csb.app/node_modules/grommet/es6/components/Drop/DropContainer.js:229:16
commitHookEffectListMount
https://z9939s.csb.app/node_modules/react-dom/cjs/react-dom.development.js:23049:26
commitPassiveMountOnFiber
https://z9939s.csb.app/node_modules/react-dom/cjs/react-dom.development.js:24816:38
commitPassiveMountEffects_complete
https://z9939s.csb.app/node_modules/react-dom/cjs/react-dom.development.js:24781:34
commitPassiveMountEffects_begin
https://z9939s.csb.app/node_modules/react-dom/cjs/react-dom.development.js:24768:41
commitPassiveMountEffects
https://z9939s.csb.app/node_modules/react-dom/cjs/react-dom.development.js:24756:34
flushPassiveEffectsImpl
https://z9939s.csb.app/node_modules/react-dom/cjs/react-dom.development.js:26990:28
flushPassiveEffects
https://z9939s.csb.app/node_modules/react-dom/cjs/react-dom.development.js:26935:14
commitRootImpl/<
https://z9939s.csb.app/node_modules/react-dom/cjs/react-dom.development.js:26725:9
workLoop
https://z9939s.csb.app/node_modules/scheduler/cjs/scheduler.development.js:266:42
flushWork
https://z9939s.csb.app/node_modules/scheduler/cjs/scheduler.development.js:239:14
performWorkUntilDeadline
https://z9939s.csb.app/node_modules/scheduler/cjs/scheduler.development.js:533:21
EventHandlerNonNull*$csb$eval/<
https://z9939s.csb.app/node_modules/scheduler/cjs/scheduler.development.js:571:3
$csb$eval
https://z9939s.csb.app/node_modules/scheduler/cjs/scheduler.development.js:633:5
H
https://codesandbox.io/static/js/sandbox.2e5f0d928.js:1:100039
evaluate
https://codesandbox.io/static/js/sandbox.2e5f0d928.js:1:112792
evaluateTranspiledModule
https://codesandbox.io/static/js/sandbox.2e5f0d928.js:1:123173
c
https://codesandbox.io/static/js/sandbox.2e5f0d928.js:1:112406
$csb$eval
https://z9939s.csb.app/node_modules/scheduler/index.js:6:20
H
https://codesandbox.io/static/js/sandbox.2e5f0d928.js:1:100039
evaluate
https://codesandbox.io/static/js/sandbox.2e5f0d928.js:1:112792
evaluateTranspiledModule
https://codesandbox.io/static/js/sandbox.2e5f0d928.js:1:123173
c
https://codesandbox.io/static/js/sandbox.2e5f0d928.js:1:112406
$csb$eval/<
https://z9939s.csb.app/node_modules/react-dom/cjs/react-dom.development.js:27:24
$csb$eval
https://z9939s.csb.app/node_modules/react-dom/cjs/react-dom.development.js:29769:5
H
https://codesandbox.io/static/js/sandbox.2e5f0d928.js:1:100039
evaluate
https://codesandbox.io/static/js/sandbox.2e5f0d928.js:1:112792
evaluateTranspiledModule
https://codesandbox.io/static/js/sandbox.2e5f0d928.js:1:123173
c
https://codesandbox.io/static/js/sandbox.2e5f0d928.js:1:112406
$csb$eval
https://z9939s.csb.app/node_modules/react-dom/index.js:37:20
H
https://codesandbox.io/static/js/sandbox.2e5f0d928.js:1:100039
evaluate
https://codesandbox.io/static/js/sandbox.2e5f0d928.js:1:112792
evaluateTranspiledModule
https://codesandbox.io/static/js/sandbox.2e5f0d928.js:1:123173
c
https://codesandbox.io/static/js/sandbox.2e5f0d928.js:1:112406
$csb$eval
https://z9939s.csb.app/node_modules/react-dom/client.js:3:16
H
https://codesandbox.io/static/js/sandbox.2e5f0d928.js:1:100039
evaluate
https://codesandbox.io/static/js/sandbox.2e5f0d928.js:1:112792
evaluateTranspiledModule
https://codesandbox.io/static/js/sandbox.2e5f0d928.js:1:123173
c
https://codesandbox.io/static/js/sandbox.2e5f0d928.js:1:112406
$csb$eval
/index.js:2
1 | import React, { useRef, useState } from "react";
> 2 | import { createRoot } from "react-dom/client";
3 |
4 | import {
5 | grommet,
View compiled
▶ 2 stack frames were collapsed.
URL, screen shot, or Codepen exhibiting the issue
https://codesandbox.io/s/grommet-v2-template-forked-z9939s?file=/index.js
Steps to Reproduce
- Use Firefox
- Go to https://z9939s.csb.app/
- Click on the Select to open the drop
- Click outside the drop
Your Environment
- Grommet version: 2.27.0
- Browser Name and version: Firefox 105.0.3
- Operating System and version (desktop or mobile): Windows 10
Metadata
Metadata
Assignees
Labels
bugissue that does not match design or documentation and requires code changes to addressissue that does not match design or documentation and requires code changes to addresshacktoberfestPRs submitted in October (open-source celebration month)PRs submitted in October (open-source celebration month)