Skip to content

[TS] type issue in DataTable/index.d.ts #6236

@thomas-friedrich

Description

@thomas-friedrich

Steps to Reproduce

  1. Run yarn tsc --noEmit from grommet folder.

Output shows a type-script related issue in components/DataTable/index.d.ts:

yarn tsc --noEmit
yarn run v1.22.18
src/js/components/DataTable/index.d.ts:130:18 - error TS2320: Interface 'DataTableExtendedProps<TRowType>' cannot simultaneously extend types 'DataTableProps<TRowType>' and 'Omit<DetailedHTMLProps<TableHTMLAttributes<HTMLTableElement>, HTMLTableElement>, "placeholder" | "onSelect">'.
  Named property 'border' of types 'DataTableProps<TRowType>' and 'Omit<DetailedHTMLProps<TableHTMLAttributes<HTMLTableElement>, HTMLTableElement>, "placeholder" | "onSelect">' are not identical.

130 export interface DataTableExtendedProps<TRowType = any>
                     ~~~~~~~~~~~~~~~~~~~~~~
Found 1 error in src/js/components/DataTable/index.d.ts:130

Your Environment

  • Grommet version: 2.25
  • Browser Name and version: N/A
  • Operating System and version (desktop or mobile): N/A

Metadata

Metadata

Assignees

Labels

bugissue that does not match design or documentation and requires code changes to addresstypescriptTypescript enhancements and bugs

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions