-
Notifications
You must be signed in to change notification settings - Fork 1k
Closed
Labels
in progressCurrently in developmentCurrently in development
Description
Expected Behavior
Similar to the custom checked icon within the CheckBox component, the StyleRadioButtonIcon
should be passed the theme
as a prop here.
The ThemeType
type should likely also match the any
value being used by checkBox.icons.checked
.
Actual Behavior
Instead there is both a type error within ThemeType
& type error when trying to pass a custom icon via radioButton.icons.circle
due to icon
being undefined.
URL, screen shot, or Codepen exhibiting the issue
Steps to Reproduce
- Create custom theme for
radioButton.icons.circle
that includes a grommet icon, like you would forcheckBox.icons.checked
e.g.
// Works 🎉
checkBox: {
icons: {
checked: Gremlin,
}
},
// Doesn't work 😢
radioButton: {
icons: {
circle: Gremlin,
}
}
- Pass theme to any component trying to render the grommet
RadioButton
component.
Your Environment
- Grommet version:
2.25.1
- Browser Name and version: Chrome Version 103.0.5060.134 (Official Build) (arm64)
- Operating System and version (desktop or mobile): Desktop - MacOS
12.5
Metadata
Metadata
Assignees
Labels
in progressCurrently in developmentCurrently in development