Adjust select icon margin #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
taysea
added a commit
that referenced
this pull request
Mar 22, 2023
* Update Next with design-system anchor and checkbox * Added next-stable configs * add branch restrictions * adding git suffix * removal of git suffix * pointing to repoURL grommet-theme-hpe * Update README.md * Update README.md * Update README.md * Update README.md * team component discussion change for drop radius * Update typography, border colors, and formfield (#41) * Update input padding (#43) * Update formfield text to use text-weak * deprecating accent and neutral colors * latest text and formfield colors plus drop and select styling * specify select up down icons from grommet-icons * elevation comments, text color value, primary button text color * button color to text-strong * latest elevation values * Allow input to respect font line-height (#48) * Update colors * Update formField styling (#51) * Update src/js/index.js Co-Authored-By: Matthew Glissmann <mdglissmann@gmail.com> * Update src/js/index.js Co-Authored-By: Matthew Glissmann <mdglissmann@gmail.com> * Update src/js/index.js Co-Authored-By: Matthew Glissmann <mdglissmann@gmail.com> * Update src/js/index.js Co-Authored-By: Shimi <shimrit.yacobi@gmail.com> * Update formfield disabled * swap values * background color adjustments, plus option pad * fix select.icons.down up * align checkbox theme with designs (#49) * align checkbox theme with designs * add to checkbox theme * Update src/js/index.js Co-Authored-By: Matthew Glissmann <mdglissmann@gmail.com> * Update src/js/index.js Co-Authored-By: Matthew Glissmann <mdglissmann@gmail.com> * Update src/js/index.js Co-Authored-By: Matthew Glissmann <mdglissmann@gmail.com> * change stroke width * Update index.js changing stroke size, the width and height are fine * Update src/js/index.js Co-Authored-By: Matthew Glissmann <mdglissmann@gmail.com> * Update index.js add hover option * change from brand green to green light or dark Co-authored-by: Brittany Archibeque <brittanyarchibeque@Brittanys-MacBook-Pro-2.local> Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> * update pad and icon color (#54) Co-authored-by: Brittany Archibeque <brittanyarchibeque@Brittanys-MacBook-Pro-2.local> * Update focus to align with designs (#56) * fix option vertical pad * Added convert-to-json * Use text-strong for Menu icon (#59) * update colors take out border focus color (#57) Co-authored-by: Brittany Archibeque <brittanyarchibeque@Brittanys-MacBook-Pro-2.local> * add in margin & hover to accordion (#61) * add in margin & hover to accordion * change values Co-authored-by: Brittany Archibeque <brittanyarchibeque@Brittanys-MacBook-Pro-2.local> * Make tab color text-strong (#60) * Add overlay background to layer (#62) * Use text-weak for placeholder (#64) * Updated new button styles * border for focus and error should be 'border-strong' per designs * Changed accordion styles * remove extra padding from select (#68) * update margins based on Slack thread 5-12-2020 * moving margin from labels to input * add auto for width (#71) Co-authored-by: Brittany Archibeque <brittanyarchibeque@Brittanys-MacBook-Pro-2.local> * upgrading font file format, plus serving from CloudFront * update FormField label weight * yarn cache clean * implement radioButton theming * remove custom JSX icon * add vertical pad to formField content * Update tabs so border extends (#77) * Update button styling based on kind=option (#79) * Update button styling based on kind=option * Remove border radius * Remove select.control * applying font weight for primary and secondary * Create release-gh-pages * Comment out release-gh-pages * Update .yml to allow release-gh-pages * Adjust file path * Undo adjust file path * Add specific files * Update add files * Update add file path * Add all * Remove delete folder * Ignore gh-pages from build and lint * Add accent-5 undefined * Add neutral-5 * Test status color * Remove test color * add tab disabled styling (#83) * simplify radiobutton check background (#84) * simplify radiobutton check background * yarn.lock * No border between list items (#85) * Update critical status color (#86) * Create PULL_REQUEST_TEMPLATE.md * add error validtion to color * change naming * revert changes * lint changes back * Update placement and update yarn.lock * Keep yellow! with yello * move formField margin from labels to content box * removes spacing between radio buttons when in RadioButtonGroup (#92) * add size for dateinput icon * move dateinput icon to correct place * Added interim theme * Remove status-error since we use status-critical (#100) * add margin to drop * Update src/js/index.js Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> * change to ignore menu for margin * update status colors to figma * yarn cache clean * Update rangeInput to match site (#103) * README: yarn required for branches (#107) npm fails to install from a branch. Use yarn instead. See issues #78 and #99. Co-authored-by: Matt Muggeridge <Matt.Muggeridge@hpe.com> * Added interim theme (#98) * Create PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * Added interim theme * Updated dependencies * Adding descriptive action-items per colors * Renamed file * Update v2migration.js * Resolved dependencies * Fix Select disabled styling (#105) * Fix Select disabled styling * opacity applies to all * Use radioButton.contaienr (#104) * Add script * First cut at Button changes for the HPE Brand refresh (#261) * Button radius change and CTA kind * add cta HPE element icon in css * remove element padding when there is no label * Update src/js/themes/hpe.js Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> * Update cta to add alternate flavor (#263) * Brand refresh b (#264) * option a - rounded buttons only * option b - fully rounded components * Brand refresh c (#265) * option a - rounded buttons only * option b - fully rounded components * option c - hybrid rounded controls, formfield hybrid * Brand refresh b (#266) * option a - rounded buttons only * option b - fully rounded components * option a - rounded buttons only (#267) * Brand refresh a (#268) * option a - rounded buttons only * remove b styling * Makes background gradients and textures available to theme (#270) * option a - rounded buttons only * remove b styling * add background gradients and textures to theme * Add HPE icon to CTA buttons and update kind-specific padding (#272) * Add icon to CTA buttons and update size padding * Cleanups * Restore rounding for non-CTA buttons * update background theme structure (#277) * Apply adjusted rounding to controls (#278) * Apply adjusted rounding to controls * Adjust large/xlarge rounding to increase proportionally * NEXT cleanups pre-release (#279) * Cleanup NEXT workflows pre-release * Revert "Cleanup NEXT workflows pre-release" This reverts commit fac1c3d. * Cleanup NEXT workflows pre-release * Remove unnecessary comment * Update DateInput to match 4px rounding * Account for color on primary button (#281) * Update README.md Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> * Update dark mode colors (#282) * 3020 typography impact eval (#291) * add Metirc font face weights * modify text color values * modify heading, paragraph, text sizing and weights * modify formfield label and input value weights * correct maxWidth * Font weight config changes (#292) * add Metirc font face weights * modify text color values * modify heading, paragraph, text sizing and weights * modify formfield label and input value weights * correct maxWidth * tweaks to weight configs * remove comment * extend heading, paragraph, text to accommodate varying weights (#293) * add Metirc font face weights * modify text color values * modify heading, paragraph, text sizing and weights * modify formfield label and input value weights * correct maxWidth * tweaks to weight configs * remove comment * extend heading, paragraph, text to accommodate varying weights * 3020 typography impact eval - modify font weights for buttons, dataTable, nameValuePair, pagination, tab, table, tag (#294) * add Metirc font face weights * modify text color values * modify heading, paragraph, text sizing and weights * modify formfield label and input value weights * correct maxWidth * tweaks to weight configs * remove comment * extend heading, paragraph, text to accommodate varying weights * modify font weights for buttons, dataTable, nameValuePair, pagination, tab, table, tag * Product typography (#295) * apply product heading sizes * uncomment paragraph.extend * update with latest on-brand specs (#305) * update with latest on-brand specs * remove unnecessary disabled overrides * fix font weights and remove extraneous properties (#306) * NEXT - fix formfield label weight (#307) * fix font weights and remove extraneous properties * fix formfield label weight * Apply iconOnly and layer backdropFilter enhancements (#309) * Update notification title styling (#315) * Theme cleanups - add comments, minor cleanups (#317) * Upgrade dependencies (#311) * Upgrade dependencies in preparation for release * Update docker image * Update simple git syntax (#312) * Update del syntax (#314) * Downgrade del, resolve simpleGit syntax (#316) * Add comments and minor cleanups * Add tab active weight * Update src/js/themes/hpe.js Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> * Update src/js/themes/hpe.js Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> * Add h1 weight --------- Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> * Add theme adjustments to align with latest discussions (#320) * Add theme adjustments to align with latest discussions * Add tab styling * Ensure accessible button label size * Align icon sizing to font-size * Remove button specific icon sizing * Replace tabs extend with new theme object * Add anchor and button cleanups * Add paragraph maxWidth * Rename hpeWeb to hpeMark * Add disabled scale down * Fix toggle, remove comments * Use Calendar title.size instead of heading * Add layer background overlay token * Fix tag, notification icon, primary gradient * Cleanup Tab * Update xlarge button * Update Menu and Select to use Down, Up icons * Remove use of Form icons * Update RangeInput and Spinner to use brand green * Update control color to brand * Align paragraph maxWidth closer to existing * Prep for safar line-height fix * Update Accordion icons * Fix for color button * StarRating, ThumbsRating, Select icon * Use 500 for medium, small anchors * Change name to hpePop * Fix index.d.ts * remove extra padding from notification icon container (#327) * Adjust select icon margin (#328) * Remove extra margin from tag remove button (#330) * Set default radius to 2em (#329) * Make default radius 2em for badge alignment on default button * Cleanups * Define menu.item.pad * Add theme.button.badge.align = container * Align badge color to button label color (#331) * Revert layer overlay changes (#332) * add color text-strong to active paginated button (#334) * update file input button styling and icons (#336) * Pagination button active font color (#335) * add color text-strong to active paginated button * modify active font color * remove incorrect location after merging NEXT * remove margin from formfield error icon (#337) * Fix small paragraph line-height (#339) * Update DataTable contract/expand icons (#338) * Update DataTable contract/expand icons * Update src/js/themes/hpe.js Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> * Update src/js/themes/hpe.js Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> * Update src/js/themes/hpe.js Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> --------- Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> * Update src/js/themes/hpe.js --------- Co-authored-by: shimisun <shimrit.yacobi@gmail.com> Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> Co-authored-by: Matt Glissmann <mdglissmann@gmail.com> Co-authored-by: britt6612 <42451602+britt6612@users.noreply.github.com> Co-authored-by: Brittany Archibeque <brittanyarchibeque@Brittanys-MacBook-Pro-2.local> Co-authored-by: LiveFreeAndRoam <LiveFreeAndRoam@gmail.com> Co-authored-by: Matt Muggeridge <Matt.Muggeridge@hpe.com> Co-authored-by: Mike Kingdom <michael.kingdom@hpe.com> Co-authored-by: Jessica Filben <54560994+jcfilben@users.noreply.github.com>
taysea
added a commit
that referenced
this pull request
Nov 1, 2023
* Update Next with design-system anchor and checkbox * Added next-stable configs * add branch restrictions * adding git suffix * removal of git suffix * pointing to repoURL grommet-theme-hpe * Update README.md * Update README.md * Update README.md * Update README.md * team component discussion change for drop radius * Update typography, border colors, and formfield (#41) * Update input padding (#43) * Update formfield text to use text-weak * deprecating accent and neutral colors * latest text and formfield colors plus drop and select styling * specify select up down icons from grommet-icons * elevation comments, text color value, primary button text color * button color to text-strong * latest elevation values * Allow input to respect font line-height (#48) * Update colors * Update formField styling (#51) * Update src/js/index.js Co-Authored-By: Matthew Glissmann <mdglissmann@gmail.com> * Update src/js/index.js Co-Authored-By: Matthew Glissmann <mdglissmann@gmail.com> * Update src/js/index.js Co-Authored-By: Matthew Glissmann <mdglissmann@gmail.com> * Update src/js/index.js Co-Authored-By: Shimi <shimrit.yacobi@gmail.com> * Update formfield disabled * swap values * background color adjustments, plus option pad * fix select.icons.down up * align checkbox theme with designs (#49) * align checkbox theme with designs * add to checkbox theme * Update src/js/index.js Co-Authored-By: Matthew Glissmann <mdglissmann@gmail.com> * Update src/js/index.js Co-Authored-By: Matthew Glissmann <mdglissmann@gmail.com> * Update src/js/index.js Co-Authored-By: Matthew Glissmann <mdglissmann@gmail.com> * change stroke width * Update index.js changing stroke size, the width and height are fine * Update src/js/index.js Co-Authored-By: Matthew Glissmann <mdglissmann@gmail.com> * Update index.js add hover option * change from brand green to green light or dark Co-authored-by: Brittany Archibeque <brittanyarchibeque@Brittanys-MacBook-Pro-2.local> Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> * update pad and icon color (#54) Co-authored-by: Brittany Archibeque <brittanyarchibeque@Brittanys-MacBook-Pro-2.local> * Update focus to align with designs (#56) * fix option vertical pad * Added convert-to-json * Use text-strong for Menu icon (#59) * update colors take out border focus color (#57) Co-authored-by: Brittany Archibeque <brittanyarchibeque@Brittanys-MacBook-Pro-2.local> * add in margin & hover to accordion (#61) * add in margin & hover to accordion * change values Co-authored-by: Brittany Archibeque <brittanyarchibeque@Brittanys-MacBook-Pro-2.local> * Make tab color text-strong (#60) * Add overlay background to layer (#62) * Use text-weak for placeholder (#64) * Updated new button styles * border for focus and error should be 'border-strong' per designs * Changed accordion styles * remove extra padding from select (#68) * update margins based on Slack thread 5-12-2020 * moving margin from labels to input * add auto for width (#71) Co-authored-by: Brittany Archibeque <brittanyarchibeque@Brittanys-MacBook-Pro-2.local> * upgrading font file format, plus serving from CloudFront * update FormField label weight * yarn cache clean * implement radioButton theming * remove custom JSX icon * add vertical pad to formField content * Update tabs so border extends (#77) * Update button styling based on kind=option (#79) * Update button styling based on kind=option * Remove border radius * Remove select.control * applying font weight for primary and secondary * Create release-gh-pages * Comment out release-gh-pages * Update .yml to allow release-gh-pages * Adjust file path * Undo adjust file path * Add specific files * Update add files * Update add file path * Add all * Remove delete folder * Ignore gh-pages from build and lint * Add accent-5 undefined * Add neutral-5 * Test status color * Remove test color * add tab disabled styling (#83) * simplify radiobutton check background (#84) * simplify radiobutton check background * yarn.lock * No border between list items (#85) * Update critical status color (#86) * Create PULL_REQUEST_TEMPLATE.md * add error validtion to color * change naming * revert changes * lint changes back * Update placement and update yarn.lock * Keep yellow! with yello * move formField margin from labels to content box * removes spacing between radio buttons when in RadioButtonGroup (#92) * add size for dateinput icon * move dateinput icon to correct place * Added interim theme * Remove status-error since we use status-critical (#100) * add margin to drop * Update src/js/index.js Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> * change to ignore menu for margin * update status colors to figma * yarn cache clean * Update rangeInput to match site (#103) * README: yarn required for branches (#107) npm fails to install from a branch. Use yarn instead. See issues #78 and #99. Co-authored-by: Matt Muggeridge <Matt.Muggeridge@hpe.com> * Added interim theme (#98) * Create PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * Added interim theme * Updated dependencies * Adding descriptive action-items per colors * Renamed file * Update v2migration.js * Resolved dependencies * Fix Select disabled styling (#105) * Fix Select disabled styling * opacity applies to all * Use radioButton.contaienr (#104) * Add script * First cut at Button changes for the HPE Brand refresh (#261) * Button radius change and CTA kind * add cta HPE element icon in css * remove element padding when there is no label * Update src/js/themes/hpe.js Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> * Update cta to add alternate flavor (#263) * Brand refresh b (#264) * option a - rounded buttons only * option b - fully rounded components * Brand refresh c (#265) * option a - rounded buttons only * option b - fully rounded components * option c - hybrid rounded controls, formfield hybrid * Brand refresh b (#266) * option a - rounded buttons only * option b - fully rounded components * option a - rounded buttons only (#267) * Brand refresh a (#268) * option a - rounded buttons only * remove b styling * Makes background gradients and textures available to theme (#270) * option a - rounded buttons only * remove b styling * add background gradients and textures to theme * Add HPE icon to CTA buttons and update kind-specific padding (#272) * Add icon to CTA buttons and update size padding * Cleanups * Restore rounding for non-CTA buttons * update background theme structure (#277) * Apply adjusted rounding to controls (#278) * Apply adjusted rounding to controls * Adjust large/xlarge rounding to increase proportionally * NEXT cleanups pre-release (#279) * Cleanup NEXT workflows pre-release * Revert "Cleanup NEXT workflows pre-release" This reverts commit fac1c3d. * Cleanup NEXT workflows pre-release * Remove unnecessary comment * Update DateInput to match 4px rounding * Account for color on primary button (#281) * Update README.md Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> * Update dark mode colors (#282) * 3020 typography impact eval (#291) * add Metirc font face weights * modify text color values * modify heading, paragraph, text sizing and weights * modify formfield label and input value weights * correct maxWidth * Font weight config changes (#292) * add Metirc font face weights * modify text color values * modify heading, paragraph, text sizing and weights * modify formfield label and input value weights * correct maxWidth * tweaks to weight configs * remove comment * extend heading, paragraph, text to accommodate varying weights (#293) * add Metirc font face weights * modify text color values * modify heading, paragraph, text sizing and weights * modify formfield label and input value weights * correct maxWidth * tweaks to weight configs * remove comment * extend heading, paragraph, text to accommodate varying weights * 3020 typography impact eval - modify font weights for buttons, dataTable, nameValuePair, pagination, tab, table, tag (#294) * add Metirc font face weights * modify text color values * modify heading, paragraph, text sizing and weights * modify formfield label and input value weights * correct maxWidth * tweaks to weight configs * remove comment * extend heading, paragraph, text to accommodate varying weights * modify font weights for buttons, dataTable, nameValuePair, pagination, tab, table, tag * Product typography (#295) * apply product heading sizes * uncomment paragraph.extend * update with latest on-brand specs (#305) * update with latest on-brand specs * remove unnecessary disabled overrides * fix font weights and remove extraneous properties (#306) * NEXT - fix formfield label weight (#307) * fix font weights and remove extraneous properties * fix formfield label weight * Apply iconOnly and layer backdropFilter enhancements (#309) * Update notification title styling (#315) * Theme cleanups - add comments, minor cleanups (#317) * Upgrade dependencies (#311) * Upgrade dependencies in preparation for release * Update docker image * Update simple git syntax (#312) * Update del syntax (#314) * Downgrade del, resolve simpleGit syntax (#316) * Add comments and minor cleanups * Add tab active weight * Update src/js/themes/hpe.js Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> * Update src/js/themes/hpe.js Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> * Add h1 weight --------- Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> * Add theme adjustments to align with latest discussions (#320) * Add theme adjustments to align with latest discussions * Add tab styling * Ensure accessible button label size * Align icon sizing to font-size * Remove button specific icon sizing * Replace tabs extend with new theme object * Add anchor and button cleanups * Add paragraph maxWidth * Rename hpeWeb to hpeMark * Add disabled scale down * Fix toggle, remove comments * Use Calendar title.size instead of heading * Add layer background overlay token * Fix tag, notification icon, primary gradient * Cleanup Tab * Update xlarge button * Update Menu and Select to use Down, Up icons * Remove use of Form icons * Update RangeInput and Spinner to use brand green * Update control color to brand * Align paragraph maxWidth closer to existing * Prep for safar line-height fix * Update Accordion icons * Fix for color button * StarRating, ThumbsRating, Select icon * Use 500 for medium, small anchors * Change name to hpePop * Fix index.d.ts * remove extra padding from notification icon container (#327) * Adjust select icon margin (#328) * Remove extra margin from tag remove button (#330) * Set default radius to 2em (#329) * Make default radius 2em for badge alignment on default button * Cleanups * Define menu.item.pad * Add theme.button.badge.align = container * Align badge color to button label color (#331) * Revert layer overlay changes (#332) * add color text-strong to active paginated button (#334) * update file input button styling and icons (#336) * Pagination button active font color (#335) * add color text-strong to active paginated button * modify active font color * remove incorrect location after merging NEXT * remove margin from formfield error icon (#337) * Fix small paragraph line-height (#339) * Update DataTable contract/expand icons (#338) * Update DataTable contract/expand icons * Update src/js/themes/hpe.js Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> * Update src/js/themes/hpe.js Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> * Update src/js/themes/hpe.js Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> --------- Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> * Update src/js/themes/hpe.js * Apply v5.1 changes * Apply suggestions from code review * Fix larger text and paragraph weights * Update src/js/themes/hpe.js * Fix build step and exports to allow npm install of branches (#362) (#368) Co-authored-by: Taylor Seamans <taylor.seamans@yahoo.com> * Remove unused object, save for future * Fix large toolbar dimensions --------- Co-authored-by: shimisun <shimrit.yacobi@gmail.com> Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> Co-authored-by: Matt Glissmann <mdglissmann@gmail.com> Co-authored-by: britt6612 <42451602+britt6612@users.noreply.github.com> Co-authored-by: Brittany Archibeque <brittanyarchibeque@Brittanys-MacBook-Pro-2.local> Co-authored-by: LiveFreeAndRoam <LiveFreeAndRoam@gmail.com> Co-authored-by: Matt Muggeridge <Matt.Muggeridge@hpe.com> Co-authored-by: Mike Kingdom <michael.kingdom@hpe.com> Co-authored-by: Jessica Filben <54560994+jcfilben@users.noreply.github.com>
taysea
added a commit
that referenced
this pull request
Feb 7, 2025
* Update README.md * Update README.md * Update README.md * team component discussion change for drop radius * Update typography, border colors, and formfield (#41) * Update input padding (#43) * Update formfield text to use text-weak * deprecating accent and neutral colors * latest text and formfield colors plus drop and select styling * specify select up down icons from grommet-icons * elevation comments, text color value, primary button text color * button color to text-strong * latest elevation values * Allow input to respect font line-height (#48) * Update colors * Update formField styling (#51) * Update src/js/index.js Co-Authored-By: Matthew Glissmann <mdglissmann@gmail.com> * Update src/js/index.js Co-Authored-By: Matthew Glissmann <mdglissmann@gmail.com> * Update src/js/index.js Co-Authored-By: Matthew Glissmann <mdglissmann@gmail.com> * Update src/js/index.js Co-Authored-By: Shimi <shimrit.yacobi@gmail.com> * Update formfield disabled * swap values * background color adjustments, plus option pad * fix select.icons.down up * align checkbox theme with designs (#49) * align checkbox theme with designs * add to checkbox theme * Update src/js/index.js Co-Authored-By: Matthew Glissmann <mdglissmann@gmail.com> * Update src/js/index.js Co-Authored-By: Matthew Glissmann <mdglissmann@gmail.com> * Update src/js/index.js Co-Authored-By: Matthew Glissmann <mdglissmann@gmail.com> * change stroke width * Update index.js changing stroke size, the width and height are fine * Update src/js/index.js Co-Authored-By: Matthew Glissmann <mdglissmann@gmail.com> * Update index.js add hover option * change from brand green to green light or dark Co-authored-by: Brittany Archibeque <brittanyarchibeque@Brittanys-MacBook-Pro-2.local> Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> * update pad and icon color (#54) Co-authored-by: Brittany Archibeque <brittanyarchibeque@Brittanys-MacBook-Pro-2.local> * Update focus to align with designs (#56) * fix option vertical pad * Added convert-to-json * Use text-strong for Menu icon (#59) * update colors take out border focus color (#57) Co-authored-by: Brittany Archibeque <brittanyarchibeque@Brittanys-MacBook-Pro-2.local> * add in margin & hover to accordion (#61) * add in margin & hover to accordion * change values Co-authored-by: Brittany Archibeque <brittanyarchibeque@Brittanys-MacBook-Pro-2.local> * Make tab color text-strong (#60) * Add overlay background to layer (#62) * Use text-weak for placeholder (#64) * Updated new button styles * border for focus and error should be 'border-strong' per designs * Changed accordion styles * remove extra padding from select (#68) * update margins based on Slack thread 5-12-2020 * moving margin from labels to input * add auto for width (#71) Co-authored-by: Brittany Archibeque <brittanyarchibeque@Brittanys-MacBook-Pro-2.local> * upgrading font file format, plus serving from CloudFront * update FormField label weight * yarn cache clean * implement radioButton theming * remove custom JSX icon * add vertical pad to formField content * Update tabs so border extends (#77) * Update button styling based on kind=option (#79) * Update button styling based on kind=option * Remove border radius * Remove select.control * applying font weight for primary and secondary * Create release-gh-pages * Comment out release-gh-pages * Update .yml to allow release-gh-pages * Adjust file path * Undo adjust file path * Add specific files * Update add files * Update add file path * Add all * Remove delete folder * Ignore gh-pages from build and lint * Add accent-5 undefined * Add neutral-5 * Test status color * Remove test color * add tab disabled styling (#83) * simplify radiobutton check background (#84) * simplify radiobutton check background * yarn.lock * No border between list items (#85) * Update critical status color (#86) * Create PULL_REQUEST_TEMPLATE.md * add error validtion to color * change naming * revert changes * lint changes back * Update placement and update yarn.lock * Keep yellow! with yello * move formField margin from labels to content box * removes spacing between radio buttons when in RadioButtonGroup (#92) * add size for dateinput icon * move dateinput icon to correct place * Added interim theme * Remove status-error since we use status-critical (#100) * add margin to drop * Update src/js/index.js Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> * change to ignore menu for margin * update status colors to figma * yarn cache clean * Update rangeInput to match site (#103) * README: yarn required for branches (#107) npm fails to install from a branch. Use yarn instead. See issues #78 and #99. Co-authored-by: Matt Muggeridge <Matt.Muggeridge@hpe.com> * Added interim theme (#98) * Create PULL_REQUEST_TEMPLATE.md * Update PULL_REQUEST_TEMPLATE.md * Added interim theme * Updated dependencies * Adding descriptive action-items per colors * Renamed file * Update v2migration.js * Resolved dependencies * Fix Select disabled styling (#105) * Fix Select disabled styling * opacity applies to all * Use radioButton.contaienr (#104) * Add script * First cut at Button changes for the HPE Brand refresh (#261) * Button radius change and CTA kind * add cta HPE element icon in css * remove element padding when there is no label * Update src/js/themes/hpe.js Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> * Update cta to add alternate flavor (#263) * Brand refresh b (#264) * option a - rounded buttons only * option b - fully rounded components * Brand refresh c (#265) * option a - rounded buttons only * option b - fully rounded components * option c - hybrid rounded controls, formfield hybrid * Brand refresh b (#266) * option a - rounded buttons only * option b - fully rounded components * option a - rounded buttons only (#267) * Brand refresh a (#268) * option a - rounded buttons only * remove b styling * Makes background gradients and textures available to theme (#270) * option a - rounded buttons only * remove b styling * add background gradients and textures to theme * Add HPE icon to CTA buttons and update kind-specific padding (#272) * Add icon to CTA buttons and update size padding * Cleanups * Restore rounding for non-CTA buttons * update background theme structure (#277) * Apply adjusted rounding to controls (#278) * Apply adjusted rounding to controls * Adjust large/xlarge rounding to increase proportionally * NEXT cleanups pre-release (#279) * Cleanup NEXT workflows pre-release * Revert "Cleanup NEXT workflows pre-release" This reverts commit fac1c3d. * Cleanup NEXT workflows pre-release * Remove unnecessary comment * Update DateInput to match 4px rounding * Account for color on primary button (#281) * Update README.md Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> * Update dark mode colors (#282) * 3020 typography impact eval (#291) * add Metirc font face weights * modify text color values * modify heading, paragraph, text sizing and weights * modify formfield label and input value weights * correct maxWidth * Font weight config changes (#292) * add Metirc font face weights * modify text color values * modify heading, paragraph, text sizing and weights * modify formfield label and input value weights * correct maxWidth * tweaks to weight configs * remove comment * extend heading, paragraph, text to accommodate varying weights (#293) * add Metirc font face weights * modify text color values * modify heading, paragraph, text sizing and weights * modify formfield label and input value weights * correct maxWidth * tweaks to weight configs * remove comment * extend heading, paragraph, text to accommodate varying weights * 3020 typography impact eval - modify font weights for buttons, dataTable, nameValuePair, pagination, tab, table, tag (#294) * add Metirc font face weights * modify text color values * modify heading, paragraph, text sizing and weights * modify formfield label and input value weights * correct maxWidth * tweaks to weight configs * remove comment * extend heading, paragraph, text to accommodate varying weights * modify font weights for buttons, dataTable, nameValuePair, pagination, tab, table, tag * Product typography (#295) * apply product heading sizes * uncomment paragraph.extend * update with latest on-brand specs (#305) * update with latest on-brand specs * remove unnecessary disabled overrides * fix font weights and remove extraneous properties (#306) * NEXT - fix formfield label weight (#307) * fix font weights and remove extraneous properties * fix formfield label weight * Apply iconOnly and layer backdropFilter enhancements (#309) * Update notification title styling (#315) * Theme cleanups - add comments, minor cleanups (#317) * Upgrade dependencies (#311) * Upgrade dependencies in preparation for release * Update docker image * Update simple git syntax (#312) * Update del syntax (#314) * Downgrade del, resolve simpleGit syntax (#316) * Add comments and minor cleanups * Add tab active weight * Update src/js/themes/hpe.js Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> * Update src/js/themes/hpe.js Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> * Add h1 weight --------- Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> * Add theme adjustments to align with latest discussions (#320) * Add theme adjustments to align with latest discussions * Add tab styling * Ensure accessible button label size * Align icon sizing to font-size * Remove button specific icon sizing * Replace tabs extend with new theme object * Add anchor and button cleanups * Add paragraph maxWidth * Rename hpeWeb to hpeMark * Add disabled scale down * Fix toggle, remove comments * Use Calendar title.size instead of heading * Add layer background overlay token * Fix tag, notification icon, primary gradient * Cleanup Tab * Update xlarge button * Update Menu and Select to use Down, Up icons * Remove use of Form icons * Update RangeInput and Spinner to use brand green * Update control color to brand * Align paragraph maxWidth closer to existing * Prep for safar line-height fix * Update Accordion icons * Fix for color button * StarRating, ThumbsRating, Select icon * Use 500 for medium, small anchors * Change name to hpePop * Fix index.d.ts * remove extra padding from notification icon container (#327) * Adjust select icon margin (#328) * Remove extra margin from tag remove button (#330) * Set default radius to 2em (#329) * Make default radius 2em for badge alignment on default button * Cleanups * Define menu.item.pad * Add theme.button.badge.align = container * Align badge color to button label color (#331) * Revert layer overlay changes (#332) * add color text-strong to active paginated button (#334) * update file input button styling and icons (#336) * Pagination button active font color (#335) * add color text-strong to active paginated button * modify active font color * remove incorrect location after merging NEXT * remove margin from formfield error icon (#337) * Fix small paragraph line-height (#339) * Update DataTable contract/expand icons (#338) * Update DataTable contract/expand icons * Update src/js/themes/hpe.js Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> * Update src/js/themes/hpe.js Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> * Update src/js/themes/hpe.js Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> --------- Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> * Update src/js/themes/hpe.js * Apply v5.1 changes * Apply suggestions from code review * Fix larger text and paragraph weights * Update src/js/themes/hpe.js * Fix build step and exports to allow npm install of branches (#362) (#368) Co-authored-by: Taylor Seamans <taylor.seamans@yahoo.com> * Remove unused object, save for future * Fix large toolbar dimensions * Theme update usign hpe-design-tokens * Add missing imports * Point to NEXT-stable for tokens * Update yarn.lock * Fix imports for stable * Remove buttonGroup, not part of grommet * Update yarn.lock * Fix updated import * Fix updated import * Update formField text anatomy names * Apply latest design tokens * Add linter ignore * Pull latest hpe-design-tokens * Update with latest changes * Fix to textSizes * Update latest sizes * Update yarn.lock * Update hpe-design-tokens, grommet, and grommet-icons dependency * Fix base color reference * Fix base color reference * Fix ThumbsRating and StarRating in FormField (#424) * Added Pagination selected.hover styling (#425) * Add all states styling for CTA buttons (#429) * Fix states for select.option (#426) * Fix states for select.option * Fix transparent background * Fix styling of TextInput and MaskedInput suggestions (#427) * Only apply :hover when not disabled (#430) * Only apply group.item.hover when not disabled * Ensure not disabled behavior applying hover extend * Remove button.extend (#431) * Fix checkbox disabled and selected states (#428) * Fix primitive color reference (#432) * Fix primitive color reference * Backwards compatible for text-xweak * Include deprecation note * Hard code rangeinput upper track (#433) * Fix bottom border on last row of DataTable (#435) * Fix bottom border on last row of datatable * Set border-color transparent at table also * Provide helpful fallback for color prop buttons (#436) * Fix clear-selection focus style (#434) * Fix clear-selection focus style * Refine style for onSearch and clear * Convert hpePop to rem * Fix 48px to rem conversion * Fix dark ref validation-warning * Undo trailing comma change in eslintrc * Remove NEXT-stable related changes to package.json --------- Co-authored-by: Shimi <shimrit.yacobi@gmail.com> Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> Co-authored-by: Matt Glissmann <mdglissmann@gmail.com> Co-authored-by: britt6612 <42451602+britt6612@users.noreply.github.com> Co-authored-by: Brittany Archibeque <brittanyarchibeque@Brittanys-MacBook-Pro-2.local> Co-authored-by: LiveFreeAndRoam <LiveFreeAndRoam@gmail.com> Co-authored-by: Matt Muggeridge <Matt.Muggeridge@hpe.com> Co-authored-by: Mike Kingdom <michael.kingdom@hpe.com> Co-authored-by: Jessica Filben <54560994+jcfilben@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an issue where SelectMultiple
showSelectedInlinecheckmark icons were not centered on small screens.Before:
After:
What testing has been done on this PR?
Tested by adjusting the theme in the grommet SelectMultiple/ShowSelectedInline story
Any background context you want to provide?
What are the relevant issues?
#319
Screenshots (if appropriate)
Is this change backward compatible or could it be a breaking change for the official HPE theme?
Backwards compatible
How should this PR be communicated in the release notes?