Remove RAC from structcpid #1352
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am reluctant to changeing MiningCPID fields, I fear that could break in suptle ways. But I see you added empty strings there so it should be fine. |
|
I will test run this a bit more, specifically syncing from 0. Changing MiningCPID shouldn't really exist. A local StructCPID instance should suffice. |
|
MiningCPID is the one put into blocks. StructCPID is for local use. Currently, that is. It should be improved. |
|
Replaced by #1480. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove RAC (and some unused stragglers) from the data structures.
These are not really used for anything concrete and only occupies RAM and some tiny storage. Due to the lack of versioning in the BOINC block data what used to be RAC fields are now empty strings. If we could solve this in a better way I'm all ears.