Skip to content

Conversation

chrstphrchvz
Copy link
Contributor

…instead of using random colors

Closes #1323

Tested on development branch using macOS, Qt 5.11.2

@EnzoCaricoTri Please see screenshot below; would you consider this an an acceptable solution? This is Qt's default color scheme, and since it is monochrome it should be colorblind-friendly.

screen shot 2018-10-21 at 3 38 26 am

…instead of using random colors

Closes #1323
@denravonska denravonska merged commit 3db367c into gridcoin-community:development Oct 21, 2018
@denravonska denravonska added this to the Camilla milestone Oct 21, 2018
@chrstphrchvz chrstphrchvz deleted the fix-1323 branch October 21, 2018 10:00
@EnzoCaricoTri
Copy link

That's much better!

@tomasbrod
Copy link
Member

Now it is noncolorblind unfriendly. The areas are all the same colour, just different shade.

@EnzoCaricoTri
Copy link

EnzoCaricoTri commented Oct 21, 2018

The current system is no better: https://gyazo.com/772471e7fa97ee8c5963d91854cc88cc edit: in a vote like this I can't distinguish anything. one solution could be to enlarge the square that appears next to the values. Effectively with a larger control sample, the comparison is easier.

@chrstphrchvz
Copy link
Contributor Author

Now it is noncolorblind unfriendly. The areas are all the same colour, just different shade.

Well, using monochrome as the default seems to only be the case only for pie charts, so I'm guessing there's a good reason for this. There's probably plenty of both research and opinions out there on this. (Yes, there's no print button, but laser printer friendliness is another factor.)

There could be more complex schemes such as having appropriate shades of green and red assigned to answers matching "Yes"/"Agree"/"Approve"/etc. and "No"/"Disagree"/"Disapprove"/etc, respectively so that there's more useful color cues. And many other things having to do with the layout rather than color.

So zapping 5 lines is just a place to start for a feature that at the moment looks hackishly thrown in rather than "designed", and was fortunate to not yet cross paths with serious data visualization folks who upon seeing such a thing would unleash their wrath on its creator.

denravonska added a commit that referenced this pull request Apr 3, 2019
Added:
 - Add `rainbymagnitude` RPC command #1235 (@Foggyx420).
 - Add stake splitting and side staking #1265 (@jamescowens).
 - Detect and block Windows shutdown so wallet can exit cleanly #1309
   (@jamescowens).
 - Add message support to sendfrom and sendtoaddress #1400 (@denravonska).

Changed:
 - Configuration options are now case insensitive #294 (@Foggyx420).
 - Update command in beaconstatus help message #1312 (@chrstphrchvz).
 - Improve synchronization speeds:
   - Refactor superblock pack/unpack #1194 (@denravonska).
   - Optimize neuralsecurity calculations #1255 (@denravonska).
   - Reduce hash calculations when checking blocks #1206 (@denravonska).
 - Make display of private key in beaconstatus OPT-IN only #1275 (@Foggyx420).
 - Store Beacon keys in Wallet #1088 (@tomasbrod).
 - Use default colors for pie chart #1333 (@chrstphrchvz).
 - Show hand cursor when hovering clickable labels #1332 (@chrstphrchvz).
 - Update README.md #1337 (@Peppernrino).
 - Fix integer overflow with displayed nonce #1297 (@personthingman2).
 - Improve application cache performance #1317 (@denravonska).
 - Improve reorg speeds #1263 (@denravonska).
 - Update Polish translation #1375 (@michalkania).

Fixed:
 - Remove expired polls from overview page #1250 (@personthingman2).
 - Fix plural text on block age #1304 (@scribblemaniac).
 - Fix researcher staking issue if your chain head was staked by you,
   #1299 (@denravonska).
 - Fix incorrect address to grcpool node #1314 (@wilkart).
 - Do not replace underscores by spaces in Qt Poll URLs #1327 (@tomasbrod).
 - Fix scraper SSL issues #1330 (@Foggyx420).

Removed:
 - Remove or merged several RPC commands #1228 (@Foggyx420):
    - `newburnaddress`, removed.
    - `burn2`: Removed.
    - `cpid`: Merged into `projects`.
    - `mymagnitude`: Merged into `magnitude`.
    - `rsa`: Removed, use `magnitude`.
    - `rsaweight`: Removed, use `magnitude`.
    - `proveownership`: Removed.
    - `encrypt`: Removed.
 - Remove obsolete POW fields from RPC responses #1358 (@jamescowens).
 - Remove obsolete netsoft fields for slight RAM requirement reduction
   #1336 (@denravonska).
 - Remove unused attachment functionality #1345 (@denravonska).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants