Change appcache to use unordered_map #1247
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iFoggz
approved these changes
Aug 7, 2018
|
RPC output of listdata and similar should be ordered. I can't check right now, but if this adds regression, create a issue for it, please. |
tomasbrod
approved these changes
Aug 8, 2018
|
You are right, it will. I'll see if there's a clean way to sort them on output. |
|
I thought about copy-constructiong a ordered map on demand in the rpc handler. |
|
That was exactly what I was going to do :D |
|
That should be pretty inexpensive memory-wise right? |
|
@jamescowens It is double the stack usage for a section when it's been converted. |
iFoggz
approved these changes
Aug 12, 2018
|
Replaced by #1317. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a small performance increase.