Fix missing poll in GUI when most recent poll expired #1455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyrossignol
commented
May 7, 2019
| // The global msPoll variable contains the poll most-recently published to | ||
| // the network. If it hasn't expired, return the title of this poll: | ||
| if (PollIsActive(msPoll)) { | ||
| return ExtractXML(msPoll, "<MK>", "</MK>").substr(0, 80); | ||
| } |
There was a problem hiding this comment.
Note: need to investigate how the alerts plug into the polls--I couldn't see how this works.
There was a problem hiding this comment.
Looks like that logic was introduced in #1250.
denravonska
reviewed
May 7, 2019
This fixes gridcoin-community#1454 by fetching an active poll from the AppCache when the most recent poll stored in msPoll expired.
66e0643 to
14348a7
Compare
|
I created a testnet alert to see if this PR affects the alert display. It does not. |
|
The PR works. The above image is from a wallet with the PR applied and the below is not... |
jamescowens
approved these changes
May 8, 2019
denravonska
approved these changes
May 8, 2019
denravonska
added a commit
that referenced
this pull request
May 10, 2019
Added: - Replace NeuralNetwork with portable C++ scraper #1387 (@jamescowens, @tomasbrod, @Cycy, @TheCharlatan, @denravonska). - Allow compile flags to be used for depends #1423 (@G-UK). - Add stake splitting and side staking info to getmininginfo #1424 (@jamescowens). - Add freedesktop.org desktop file and icon set #1438 (@a123b). Changed: - Disable Qt for windows Travis builds #1276 (@TheCharlatan). - Replace use of AppCache PROJECT section with strongly-typed structures #1415 (@cyrossignol). - Change dumpwallet to use appropriate data directory #1416 (@jamescowens). - Optimize ExtractXML() calls by avoiding unnecessary string copies #1419 (@cyrossignol). - Change signature of IsLockTimeWithinMinutes #1422 (@jamescowens). - Restore old poll output for getmininginfo RPC #1437 (@a123b). - Prevent segfault when using rpc savescraperfilemanifest #1439 (@jamescowens). - Improve miner status messages for ineligible staking balances #1447 (@cyrossignol). - Enhance scraper log archiving #1449 (@jamescowens). Fixed: - Re-enable full GUI 32-bit Windows builds - part of #1387 (@jamescowens). - Re-activate Windows Installer #1409 (@TheCharlatan). - Fix Depends and Travis build issues for ARM #1417 (@jamescowens). - Fix syncupdate icons #1421 (@jamescowens). - Fix potential BOINC crash when reading projects #1426 (@cyrossignol). - Fix freeze when unlocking wallet #1428 (@denravonska). - Fix RPC after high priority alert #1432 (@denravonska). - Fix missing poll in GUI when most recent poll expired #1455 (@cyrossignol). Removed: - Remove old, rudimentary side staking implementation #1381 (@denravonska). - Remove auto unlock #1402 (@denravonska). - Remove superblock forwarding #1430 (@denravonska).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1454 by fetching the next most recent active poll from the
AppCachewhen the poll stored inmsPollexpired. The most recent poll published to the network is not necessarily the poll that expires last--an earlier poll could exist that expires later.Also updates the RPC output from #1437.