Skip to content

Conversation

haneug
Copy link
Contributor

@haneug haneug commented Dec 9, 2022

  • Simple initial commit for spin-polarization

Signed-off-by: haneug hagen@thch.uni-bonn.de

Signed-off-by: haneug <hagen@thch.uni-bonn.de>
@haneug haneug changed the title Initial commit for spin-polarization in xtb Spin-polarization in xTB Dec 9, 2022
@haneug haneug self-assigned this Dec 9, 2022
@haneug haneug added enhancement New feature or request method: xTB Related to the xTB Hamiltonian and its parametrisations library: tblite Related to the tblite library dependency labels Dec 9, 2022
@haneug haneug added this to the v6.6.0 milestone Dec 11, 2022
@haneug haneug requested review from Albkat and MtoLStoN March 6, 2023 10:11
@haneug haneug marked this pull request as ready for review March 6, 2023 10:12
case('--spinpol')
if (get_xtb_feature('tblite')) then
call env%warning("Employing tblite library for spin-polarization", source)
call set_exttyp('tblite')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should only raise a warning if --tblite is not manually specified. Maybe check after evaluating all arguments if --spinpol has been set without using tblite. Then you can also write a more specified warning (i.e. suggesting the user to explicitly order tblite to be used)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a check for the tblite. Other checks regarding tblite will be added in a separate PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I had to transfer your check from the newCalculator subroutine to the xtbMain. Apparently, this subroutine is used for the iff and docking unit tests, and could not be modified in such way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, alternatively one could have checked if the optional tblite_input is present.

@haneug haneug requested a review from MtoLStoN March 16, 2023 16:16
Signed-off-by: albert <92109627+Albkat@users.noreply.github.com>
@haneug haneug merged commit 767c9c1 into grimme-lab:main Mar 17, 2023
@haneug haneug deleted the spin-polarization branch March 17, 2023 07:37
@Albkat Albkat mentioned this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request library: tblite Related to the tblite library dependency method: xTB Related to the xTB Hamiltonian and its parametrisations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants