-
Notifications
You must be signed in to change notification settings - Fork 170
Integrate tblite library for evaluating xTB Hamiltonians #626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a57f5b7
to
8560e0c
Compare
aa96db5
to
4cdb451
Compare
This is mostly complete, in case anyone is interested in helping to get it merged let me know. |
5dce44d
to
f3079b5
Compare
Ready for review. |
- Support for passing through options to tblite - Update OpenMP linking
I cannot compile a static version of this anymore with the latest intel compiler (using -static -OpenMP linking flags). However, some trial and error let me narrow this down to the A way to fix this via the meson build system would be to add an ifcoremt library dependency to tblite. lib_deps += fc.find_library('ifcoremt') somewhere here But this probably needs to be customized for the various compilers we use. |
Yes, that is due to libraries without direct OpenMP dependency in the tree, but will only pop up for static linking with Intel. For dist I recommend to use Linux
Windows (powershell)
Might work to just drop-in |
Signed-off-by: MtoLStoN <70513124+MtoLStoN@users.noreply.github.com>
Agree. As stated, adding an explicit -lifcoremt linker flag works for me for static linking. However, the dynamic build needs an additional "-qopenmp" linker flag to compile, which is nothing terrible, but we should probably include that in the README to prevent future questions. Otherwise, this looks good to me. |
Thanks for sharing. |
allow creation of solvation models(separate PR)provide info printout from parametrization(separate PR)Closes #514