Skip to content

Conversation

MtoLStoN
Copy link
Contributor

Fixed problems with charged Compounds containing phosphor for GFN2/ALPB by reoptimizing the water parameters.

Parametrized the solvents Methanol and Ethanol for the ALPB Method.

Signed-off-by: MtoLStoN <70513124+MtoLStoN@users.noreply.github.com>
Added ALPB Parameters for Methanol and Ethanol.

Signed-off-by: MtoLStoN <70513124+MtoLStoN@users.noreply.github.com>
@MtoLStoN MtoLStoN requested a review from awvwgk November 27, 2020 13:12
Signed-off-by: MtoLStoN <70513124+MtoLStoN@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Nov 27, 2020

Codecov Report

Merging #387 (aaef960) into master (a7d28e9) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #387   +/-   ##
=======================================
  Coverage   40.60%   40.60%           
=======================================
  Files         301      301           
  Lines       50564    50570    +6     
=======================================
+ Hits        20529    20533    +4     
- Misses      30035    30037    +2     
Impacted Files Coverage Δ
TESTSUITE/gfn0.f90 98.03% <ø> (ø)
TESTSUITE/gfn1.f90 100.00% <ø> (ø)
TESTSUITE/gfn2.f90 75.54% <ø> (ø)
TESTSUITE/gfnff.f90 100.00% <ø> (ø)
src/solv/model.f90 51.20% <0.00%> (ø)
src/set_module.f90 27.96% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7d28e9...aaef960. Read the comment docs.

Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@awvwgk awvwgk merged commit a3110b3 into grimme-lab:master Nov 27, 2020
@awvwgk awvwgk added this to the v6.4.0 milestone Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants