-
Notifications
You must be signed in to change notification settings - Fork 172
Add COSMO implicit solvation model #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
awvwgk
commented
Jun 23, 2020
- use ddCOSMO library to solve COSMO equations
Looks great! Is it possible to get the solvent volume / surface area printed as computed properties (or via the Python API). I'd love to use XTB / CREST to augment solubility predictions. |
See #336 for the extension of the C-API w.r.t. to solvation. I have not yet decided on the necessary API objects and calls to implement this, but it is on the list. |
I also saw in the documentation about:
This looks like it would give what we want - grabbing the SASA (even h-bond terms). |
7080355
to
06736f2
Compare
Codecov Report
@@ Coverage Diff @@
## master #274 +/- ##
==========================================
+ Coverage 40.79% 41.77% +0.97%
==========================================
Files 304 307 +3
Lines 50792 51721 +929
==========================================
+ Hits 20722 21605 +883
- Misses 30070 30116 +46
Continue to review full report at Codecov.
|
- use ddCOSMO library to solve COSMO equations