Skip to content

listen for http.request error #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

listen for http.request error #93

wants to merge 1 commit into from

Conversation

cheapsteak
Copy link

Was running into

events.js:163
      throw er; // Unhandled 'error' event
      ^

Error: socket hang up
    at createHangUpError (_http_client.js:302:15)
    at Socket.socketOnEnd (_http_client.js:394:23)
    at emitNone (events.js:91:20)
    at Socket.emit (events.js:188:7)
    at endReadableNT (_stream_readable.js:975:12)
    at _combinedTickCallback (internal/process/next_tick.js:80:11)
    at process._tickCallback (internal/process/next_tick.js:104:9)

Found the issue via this SO thread:

whenever you emit an 'error' event and no one listens to it, it will throw.

In this case the culprit seems to be the http.request that's missing a listener for the error

Should fix #60

@roninhack
Copy link

Not enough for windows and mac. Error handling not catching in windows.
EADDRINUSE , ECONNRESET and "Unknown Error" can not handling in windows.

@mfgea
Copy link

mfgea commented Aug 31, 2018 •
edited
Loading

I tracked this error down. Seems to be happenning when creating the tlsSpoofing server and it's corresponding request; none of those are handling errors:

In lib/proxy.js (line ~230):

      this._tlsSpoofingServer = https.createServer({
        key,
        cert,
        SNICallback,
      }, (fromClient, toClient) => {
        let shp = 'https://' + fromClient.headers.host
          , fullUrl = shp + fromClient.url
          , addr = this._server.address()
        let toServer = http.request({
          host: 'localhost',
          port: addr.port,
          method: fromClient.method,
          path: fullUrl,
          headers: fromClient.headers,
        }, fromServer => {
          toClient.writeHead(fromServer.statusCode, fromServer.headers)
          fromServer.pipe(toClient)
        })
        fromClient.pipe(toServer)
      })

Adding error listeners to the toServer request and the this._tlsSpoofingServer seems to solve the issue of the app crashing:

      this._tlsSpoofingServer = https.createServer({
        key,
        cert,
        SNICallback,
      }, (fromClient, toClient) => {
        let shp = 'https://' + fromClient.headers.host
          , fullUrl = shp + fromClient.url
          , addr = this._server.address()
        let toServer = http.request({
          host: 'localhost',
          port: addr.port,
          method: fromClient.method,
          path: fullUrl,
          headers: fromClient.headers,
        }, fromServer => {
          toClient.writeHead(fromServer.statusCode, fromServer.headers)
          fromServer.pipe(toClient)
        })
        toServer.on('error', (err) => {
            this.emit('error', err);
        })
        fromClient.pipe(toServer)
      })
      _this._tlsSpoofingServer.on('error', (err) => {
          this.emit('error', err);
      })

I'll send a PR later today

@mfgea mfgea mentioned this pull request Aug 31, 2018
Open
This was referenced Sep 17, 2018
Closed
Merged
@greim
Copy link
Owner

greim commented Sep 19, 2018

Thanks for this. A similar fix just landed in #109

@greim greim closed this Sep 19, 2018
@jamezrin jamezrin mentioned this pull request Jan 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

socket error not handled
4 participants
@cheapsteak @roninhack @mfgea @greim