bug: Let classic python version work without grpc deps #647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kimahriman
commented
Jul 17, 2025
python/graphframes/graphframe.py
Outdated
| return GraphFrame(impl.vertices, impl.edges) | ||
|
|
||
| def __init__(self, v: DataFrame, e: DataFrame) -> None: | ||
| self._impl: GraphFrameClassic | 'GraphFrameConnect' |
There was a problem hiding this comment.
There's a lot of typing issues but fixed this one at least while I was here. _impl defaulted to the first thing assigned to it which was GraphFrameConnect
There was a problem hiding this comment.
I hope one day to implement something cool instead, like spark's decorator about dynamic dispatch... This "_impl" based realization is not perfect :(
|
jfyi: There is a pre-comfigured pre-commit.
|
SemyonSinchenko
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #646
What changes were proposed in this pull request?
Lazily import connect client to avoid import errors if not trying to use connect. If the user is using connect (i.e.
is_remote()is true), it will throw an error if there is a dependency issue when creating the graphframe object.Why are the changes needed?
To let the python package work with classic spark without grpc related dependencies installed.