fix: resolve gf-connect is not published #645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @Kimahriman for the suggestion! I tried |
Kimahriman
reviewed
Jul 17, 2025
Kimahriman
reviewed
Jul 17, 2025
|
IMO it would be cleaner to just have |
Co-authored-by: Adam Binford <adamq43@gmail.com>
Co-authored-by: Adam Binford <adamq43@gmail.com>
Kimahriman
reviewed
Jul 17, 2025
|
One last other thing I noticed. The Spark 3 build is built with Java 11, but Spark 3 does support Java 8 so the released artifacts should be built with Java 8 |
Co-authored-by: Adam Binford <adamq43@gmail.com>
|
And again thanks a lot @Kimahriman ! Your experience is helping a lot to GraphFarmes to become better!! |
|
I will update |
rjurney
approved these changes
Jul 17, 2025
|
Oh wait, CI failed... |
Kimahriman
reviewed
Jul 17, 2025
Co-authored-by: Adam Binford <adamq43@gmail.com>
@Kimahriman resolved the puzzle (see comments in the issue). Mostly it was my fault, I was needed to refactor it to the right multi-project sbt layout when I introduced connect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refactoring according the comment
Why are the changes needed?
Close #639