Skip to content

fix: remove version.sbt #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

SemyonSinchenko
Copy link
Collaborator

@SemyonSinchenko SemyonSinchenko commented Jul 17, 2025

What changes were proposed in this pull request?

  • remove version.sbt

sbt-ci-release correctly determines the version without this file. Otherwise the release-CI is not working at all, see #635

Why are the changes needed?

Close #635

@SemyonSinchenko SemyonSinchenko self-assigned this Jul 17, 2025
@SemyonSinchenko
Copy link
Collaborator Author

From the CI logs (Python CI):

[info] Built: /home/runner/work/graphframes/graphframes/graphframes-connect/target/scala-2.13/graphframes-connect-spark4_2.13-0.0.0+1-9996b40f-SNAPSHOT-spark4.0.jar

As you can see, the version is automatically generated by the plugin based on the github tags. The only reason version is 0.0.0 here is because sbt-ci-release requires:

    steps:
      - name: Check out code
        uses: actions/checkout@v4
        with:
          fetch-depth: 0

to get the full git history and tags information. It is specified in publishing CI, but it is not needed for testing.

I also tested it locally and it works fine:

sbt:graphframes> publishLocal
[info] Wrote /var/home/sem/github/graphframes/target/scala-2.12/graphframes-spark3_2.12-0.9.0+1-f554aaf9-SNAPSHOT-spark3.5.pom

where f554aaf9 is exactly the hash of the commit of this PR.

So, long story short, it works.

@james-willis
Copy link
Collaborator

How do snapshots work now?

@SemyonSinchenko
Copy link
Collaborator Author

How do snapshots work now?

In the same way except the commit hash is added to the version string

@SemyonSinchenko SemyonSinchenko merged commit 3c07f9d into graphframes:master Jul 17, 2025
5 checks passed
@SemyonSinchenko SemyonSinchenko deleted the 635-fix-sbt-ci-release branch July 19, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: sbt-ci-release does not take the versions from tag and use "SNAPSHOT"
2 participants