Skip to content

Conversation

SemyonSinchenko
Copy link
Collaborator

@SemyonSinchenko SemyonSinchenko commented Feb 25, 2025

What changes were proposed in this pull request?

  • replace outdated olafurpg/setup-scala by setup-java action
  • force the run of the scalafmtCheckAll during the CI

Why are the changes needed?

As described in #514

Close #514

+ force scalfmt checkAll during the CI
@SemyonSinchenko
Copy link
Collaborator Author

@rjurney @bjornjorgensen Hello! Could you review this one when you have time? Thanks!

Copy link
Collaborator

@rjurney rjurney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@bjornjorgensen bjornjorgensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjornjorgensen
Copy link
Contributor

@SemyonSinchenko if you type fix #514 in the PR they will be linked and the 514 will be closed automatically when this PR is merged.

@rjurney
Copy link
Collaborator

rjurney commented Feb 25, 2025

fix #514

@rjurney rjurney merged commit 6782187 into graphframes:master Feb 25, 2025
3 checks passed
@SemyonSinchenko SemyonSinchenko deleted the 514-setup-scala branch April 6, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace olafurpg/setup-scala
3 participants