Skip to content

Conversation

bjornjorgensen
Copy link
Contributor

This pull request includes several changes aimed at improving the codebase by ensuring consistency in the use of toIndexedSeq and toSeq methods, along with some minor refactoring. The most important changes include updates to the GraphFrame class and related objects, as well as updates to other classes and objects within the graphframes package.

Improvements to GraphFrame class and related objects:

Refactoring in other classes and objects:

This removes warnings when we build. Note we can't use WrappedArray if we will have support for Scala 2.12

@bjornjorgensen
Copy link
Contributor Author

@rjurney can you have a look

@rjurney
Copy link
Collaborator

rjurney commented Jan 16, 2025

@rjurney can you have a look

Hey, yeah I'll test this today.

@rjurney rjurney merged commit 06fd2ae into graphframes:master Jan 17, 2025
3 checks passed
@rjurney
Copy link
Collaborator

rjurney commented Jan 17, 2025

@bjornjorgensen I meant today :D Okay, this works for me on Java 8 and 11 and passes all tests... once I git pull origin master to give it the ability to ignore unknown options and run on Java 8. It passes all checks. Merging. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants