-
Notifications
You must be signed in to change notification settings - Fork 252
Update scala code #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rjurney
merged 19 commits into
graphframes:master
from
bjornjorgensen:update-scala-code
Jan 17, 2025
Merged
Update scala code #479
rjurney
merged 19 commits into
graphframes:master
from
bjornjorgensen:update-scala-code
Jan 17, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@rjurney can you have a look |
Hey, yeah I'll test this today. |
@bjornjorgensen I meant today :D Okay, this works for me on Java 8 and 11 and passes all tests... once I |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes aimed at improving the codebase by ensuring consistency in the use of
toIndexedSeq
andtoSeq
methods, along with some minor refactoring. The most important changes include updates to theGraphFrame
class and related objects, as well as updates to other classes and objects within thegraphframes
package.Improvements to
GraphFrame
class and related objects:src/main/scala/org/graphframes/GraphFrame.scala
: Modified thetoString
method to usetoIndexedSeq
andtoSeq
for column selection consistency.src/main/scala/org/graphframes/GraphFrame.scala
: UpdatedfromEdges
method to usedistinct()
instead ofdistinct
.src/main/scala/org/graphframes/GraphFrame.scala
: UpdatedcolStar
andnestAsCol
methods to usetoIndexedSeq
andtoSeq
respectively. [1] [2]Refactoring in other classes and objects:
src/main/scala/org/graphframes/examples/BeliefPropagation.scala
: Ensured consistent use oftoInt
conversion aftercount()
method inrunBPwithGraphX
andrunBPwithGraphFrames
methods. [1] [2]src/main/scala/org/graphframes/examples/Graphs.scala
: UpdatedALSSyntheticData
method to usetoIndexedSeq
for data and vertices.src/main/scala/org/graphframes/lib/BFS.scala
: Modifiedpaths.select
to usetoSeq
for column selection.src/main/scala/org/graphframes/lib/GraphXConversions.scala
: Updatedselect
method to usetoSeq
for field selection.src/main/scala/org/graphframes/lib/ShortestPaths.scala
: Replacedscala.collection.JavaConverters
withscala.jdk.CollectionConverters
.src/main/scala/org/graphframes/lib/ShortestPaths.scala
: Updatedselect
method to usetoSeq
for column selection.src/main/scala/org/graphframes/lib/TriangleCount.scala
: Modifiedselect
method to usetoSeq
for column selection.This removes warnings when we build. Note we can't use WrappedArray if we will have support for Scala 2.12