Use vertices SparkSession #474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use vertices `SparkSession` instead of the thread's
|
@Nassizouz is there any way you can create a simple unit test for this? |
|
@rjurney Added a simple unittest |
|
@Nassizouz Testing this now... thanks for the bugfix :) Keep it coming! I need to merge my fix for Java 8 before I can test this in Java 8, one minute... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version of the
GraphFrameclass used the vertices SQLContext, when the code was changed to use SparkSession the thread's session was taken, this change can break old working code if the GraphFrame is initialized in a thread that didn't initialized a spark session.This PR uses the vertices SparkSession so it will work regardless to whether a spark session was initialized on the current thread