Skip to content

Conversation

eejbyfeldt
Copy link

This add CI builds for spark 3.3.0 and updates to 3.2.2 and 3.1.3.

The new build for 3.3.0 required some small changes in the testsuite for it to run without failures.

Emil Ejbyfeldt added 2 commits August 17, 2022 09:05
Add CI build for spark 3.3.0

Upgrade spark 3.2.0 to 3.2.2

Upgrade spark 3.1.2 to 3.1.3
The previous setup would cause test to end up using a stopped spark
context causing them to fail. This seems to be due to some change in
spark 3.3.0, by making the whole suite using a single SparkContext this
issue goes away.
@eejbyfeldt
Copy link
Author

Tagging @mengxr and @WeichenXu123 for visibility since you most recently reviewed/merged PRs. But since this was several months back, please let me know if you are no longer maintaining this project and if there anyone else is?

@eejbyfeldt
Copy link
Author

Tagging @felixcheung and @jkbradley who are in the graphframes organization. Do you know if there anyone who is currently interested reviewing PRs for this repository?

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2022

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.37%. Comparing base (4a5b3d9) to head (f11cc6c).
Report is 17 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #415      +/-   ##
==========================================
+ Coverage   91.26%   91.37%   +0.11%     
==========================================
  Files          18       18              
  Lines         870      870              
  Branches       53       53              
==========================================
+ Hits          794      795       +1     
+ Misses         76       75       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dbczumar dbczumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @eejbyfeldt!

@WeichenXu123 can you also take a quick look?

Copy link
Contributor

@WeichenXu123 WeichenXu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WeichenXu123 WeichenXu123 merged commit 100fb01 into graphframes:master Aug 25, 2022
@eejbyfeldt
Copy link
Author

Thanks, @dbczumar and @WeichenXu123 for having a look!

I also created a "follow up" here PR: #417 adding support for Scala 2.13 for the spark releases that provides pre-built version with it. I would be very grateful if you had a look at that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants