-
Notifications
You must be signed in to change notification settings - Fork 252
Description
Is your feature request related to a problem? Please describe.
During the last check of an existing publishing CI I found an issue. sbt-ci-release
requires (strictly) git tags to have a "v"-prefix, like "v0.9.0" (not just "0.9.0"). But an existing python-publish CI is just calling poetry version ${{ github.ref_name }}
that will set the version to "v0.9.0" (not just "0.9.0"). But "v0.9.0" is not a valid version for the PyPi central and most probably the release will be rejected.
Describe the solution you would like
Add https://pypi.org/project/poetry-dynamic-versioning/ as poetry plugin as described in it's documentation. It will carefully extract the version from git tag during the build, so it will allow to simplify the CI as a side effect (the line poetry version ${{ github.ref_name }}
won't be needed anymore).
Component
- Scala Core Internal
- Scala API
- Spark Connect Plugin
- Infrastructure
- PySpark Classic
- PySpark Connect
Additional context
Highest priority, it blocks the 0.9.0 release.
Are you planning on creating a PR?
- I'm willing to make a pull-request